Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens list #62

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Tokens list #62

merged 2 commits into from
Oct 17, 2022

Conversation

LeeAlephium
Copy link
Contributor

@LeeAlephium LeeAlephium commented Sep 9, 2022 •
edited
Loading

  1. Need to create an amount and prices store
  2. Need to hook up at the very least fake requests
  3. Need to clean code

Screenshot_20220909-115001_mobile-wallet

@LeeAlephium LeeAlephium changed the base branch from master to dark-mode-fixes September 9, 2022 19:26
@LeeAlephium
Copy link
Contributor Author

LeeAlephium commented Sep 13, 2022 •
edited
Loading

Remaining:

  • Better height calculation
  • Sorting
  • Refactoring?

@LeeAlephium
Copy link
Contributor Author

FWIW the carousel package we're using doesn't support dynamic height: dohooo/react-native-reanimated-carousel#88

I think I know how to do it regardless but still, thought it was noteworthy

@LeeAlephium LeeAlephium linked an issue Sep 19, 2022 that may be closed by this pull request
Start displaying tokens 🪙 #57
Closed
@LeeAlephium LeeAlephium changed the title WIP: Tokens list Tokens list Sep 19, 2022
@LeeAlephium LeeAlephium changed the base branch from dark-mode-fixes to master September 19, 2022 18:26
@LeeAlephium LeeAlephium requested review from nop33 and removed request for mvaivre September 21, 2022 15:51
@nop33 nop33 force-pushed the token-list branch 10 times, most recently from 0144fe3 to cb4f0c4 Compare October 17, 2022 19:27
@nop33 nop33 merged commit 66ae930 into master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nop33 nop33 Awaiting requested review from nop33

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start displaying tokens 🪙
2 participants
@LeeAlephium @nop33