feat: Add ClojureScript support #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why?: - The general mechanics for ClojureScript should be the same as for Clojure, but at the moment only *.clj files are considered which hinders ClojureScript support. This change addresses the need by: - Adding .cljs as possible file extensions to encounter
alexander-yakushev
force-pushed
the
master
branch
3 times, most recently
from
48ed5bc
to
24cae85
Compare
|
Probably this PR was made redundant by #91 Anyway, as for clojurescript support, please note that CIDER's approach is to include https://github.com/clojure-emacs/clj-suitable which extends Compliment. That lib isn't exactly perfect, but it got some maintenance, and there's more to come. Issues welcome. |
|
Yes, thank you for pointing this out, @vemv. @niontrix: unfortunately, adding ClojureScript support to Compliment requires quite a lot more work than this change. We went through that path before in #62 and ultimately decided to keep CLJS completion in a separate library. Still, I thank you for wanting to contribute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?:
This change addresses the need by:
P.S.:
This is my humble attempt to add ClojureScript support. Unfortunately I'm not that proficient of a Clojure developer yet, so I appreciate any directions you can give me if you think that my crack at adding ClojureScript support is the wrong way to go. But it seemed to work as expected when I tried it locally in combination with CIDER.