-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 5 minute data from vnstat 2.x - compatible with vnstat 1.x #37
base: master
Are you sure you want to change the base?
Conversation
Tested against vnstat 2.3 and vnstat 1.14
Use 'current' google chart version
5min graph duration adjusts automatically to screen width
Make graphs taller More digits in graph data
Clean up base calculation
Enable graph explorer
Add zoom/pan instructions
Fix vnstat v1 compatibility
Add zoom and pan capability to 5min/hour/day graphs |
@tomangert thanks for doing some work on this and getting it up to date. I'll have a look at this PR in detail tonight hopefully. Does PR #36 need to be closed now this one is open? |
Yes 36 can be closed - changes from 36 are included in 37. |
A few comments with this one initially, @tomangert :
|
|
@tomangert can you update your copy against the new changes and we can have a look what it looks like. |
ok - probably tonight. (gmt-4 here) |
support for vnstat v2 support for 5 minute data vnstat v1 compatible So far - graph in first tab is OK, other tabs are small and incomplete
support for vnstat v2 support for 5 minute data vnstat v1 compatible So far - graph in first tab is OK, other tabs are small and incomplete
Hey - any update on this? |
Mostly working
…tat1 support is preserved (works with both)
The history on this is a bit of a mess. The end result is 5 files with changes. Let me know if I should redo this in a new pull request. |
@tomangert this looks good. Have you got an example of this running with the 5 minute dataset? |
Example sent in an email. The current merge request is the minimum changes to get something working. Problems / enhancements left to deal with (~decreasing severity):
The rest are not directly 5 minute/vnstat2 related and may just be my preferences.
|
Allow wider range of zoom
Fixs and enhancments
Fix occasional display error. Clean up some floatingpoint math
Add logarithmic graph option.
Tested with vnstat 2.3 and vnstat 1.14 on Ubuntu 16.04 / Apache 2.4.39