From cf9dd7008e0695619e067853007a4774d2092dfe Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Sat, 26 Apr 2014 10:24:47 -0700 Subject: [PATCH] rustc: Don't die on 0-length pattern idents These often crop up when using default methods that don't actually bind their argument names. Closes #13775 --- src/librustc/middle/lint.rs | 2 +- src/test/run-pass/issue-13775.rs | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 src/test/run-pass/issue-13775.rs diff --git a/src/librustc/middle/lint.rs b/src/librustc/middle/lint.rs index 51aafb90ac656..f8c1aaf674cd4 100644 --- a/src/librustc/middle/lint.rs +++ b/src/librustc/middle/lint.rs @@ -1239,7 +1239,7 @@ fn check_pat_uppercase_variable(cx: &Context, p: &ast::Pat) { // last identifier alone is right choice for this lint. let ident = path.segments.last().unwrap().identifier; let s = token::get_ident(ident); - if s.get().char_at(0).is_uppercase() { + if s.get().len() > 0 && s.get().char_at(0).is_uppercase() { cx.span_lint( UppercaseVariables, path.span, diff --git a/src/test/run-pass/issue-13775.rs b/src/test/run-pass/issue-13775.rs new file mode 100644 index 0000000000000..8731662afa307 --- /dev/null +++ b/src/test/run-pass/issue-13775.rs @@ -0,0 +1,15 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +trait Foo { + fn bar(&self, int) {} +} + +fn main() {}