-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeaderMode::Deterministic differs in behaviour on Unix and Windows platforms #341
Comments
mkaput
added a commit
to software-mansion/scarb
that referenced
this issue
Nov 13, 2023
Although the `set_metadata_in_mode` call should set `mtime` to a deterministic value, it fails to do so due to alexcrichton/tar-rs#341. Also, the constant value used there is funky and I do not feel convinced about its stability. Therefore, we use our own `mtime` value explicitly here. Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
mkaput
added a commit
to software-mansion/scarb
that referenced
this issue
Nov 13, 2023
Although the `set_metadata_in_mode` call should set `mtime` to a deterministic value, it fails to do so due to alexcrichton/tar-rs#341. Also, the constant value used there is funky and I do not feel convinced about its stability. Therefore, we use our own `mtime` value explicitly here. fix #883 Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
This was referenced Nov 13, 2023
github-merge-queue bot
pushed a commit
to software-mansion/scarb
that referenced
this issue
Nov 13, 2023
Although the `set_metadata_in_mode` call should set `mtime` to a deterministic value, it fails to do so due to alexcrichton/tar-rs#341. Also, the constant value used there is funky and I do not feel convinced about its stability. Therefore, we use our own `mtime` value explicitly here. fix #883 Signed-off-by: Marek Kaput <marek.kaput@swmansion.com>
alexcrichton
pushed a commit
that referenced
this issue
Jun 4, 2024
ararslan
pushed a commit
to ararslan/binstall-tar
that referenced
this issue
Jun 6, 2024
* Unify `mtime` constant used on Unix and Windows fix alexcrichton#341 * Extract `DETERMINISTIC_TIMESTAMP` (cherry picked from commit dd9123c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Windows the
mtime
is set to the dummy value of https://github.com/alexcrichton/tar-rs/blob/master/src/header.rs#L828but on Unix it is set to https://github.com/alexcrichton/tar-rs/blob/master/src/header.rs#L760
I don't see why these should be different, and it causes an annoyance in one of our use-cases.
Is there a reason why these two dummy values should be different?
The text was updated successfully, but these errors were encountered: