-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/volumes #19
Feat/volumes #19
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! 💪
Our CI is currently complaining because older examples make use of compute_lmds()
, which was renamed to compute_lmds_mesh()
.
I have made a few suggestions, mostly typos and naming.
Here is a list of ideas to track for future reference:
- adding the
method
parameter tocompute_lmds_mesh()
- checking what happens when our volumetric segmentation has more than one connected component
examples/02_volumetric_alignment/plot_1_aligning_low_res_volumes.py
Outdated
Show resolved
Hide resolved
examples/02_volumetric_alignment/plot_1_aligning_low_res_volumes.py
Outdated
Show resolved
Hide resolved
examples/02_volumetric_alignment/plot_1_aligning_low_res_volumes.py
Outdated
Show resolved
Hide resolved
examples/02_volumetric_alignment/plot_1_aligning_low_res_volumes.py
Outdated
Show resolved
Hide resolved
examples/02_volumetric_alignment/plot_1_aligning_low_res_volumes.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Corrected PR strictly for the addition of volumetric features. Examples are now written in
.py
instead of.ipynb
.