Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/volumes #19

Merged
merged 9 commits into from
May 9, 2023
Merged

Feat/volumes #19

merged 9 commits into from
May 9, 2023

Conversation

pbarbarant
Copy link
Collaborator

Corrected PR strictly for the addition of volumetric features. Examples are now written in .py instead of .ipynb.

Copy link
Owner

@alexisthual alexisthual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! 💪

Our CI is currently complaining because older examples make use of compute_lmds(), which was renamed to compute_lmds_mesh().

I have made a few suggestions, mostly typos and naming.

Here is a list of ideas to track for future reference:

  • adding the method parameter to compute_lmds_mesh()
  • checking what happens when our volumetric segmentation has more than one connected component

Copy link
Owner

@alexisthual alexisthual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alexisthual alexisthual merged commit 19ad64b into alexisthual:main May 9, 2023
@pbarbarant pbarbarant deleted the feat/volumes branch August 23, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants