This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Prevent crashes when working with ES2015 symbols #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redux-devtools-inspector crashed when using symbols.
The two following things caused the crashes:
javascript-stringify
did not support symbols whereas the previously usedjsan
did. Here's the PR I sent them to fix this (merged).getShortTypeString
inActionPreview.jsx
did not support Symbols, so it tried using them as strings, which is not supported and caused the errorUncaught TypeError: Cannot convert a Symbol value to a string
This corrected, there is still a problem as Symbol values are not shown in JSONTree. Here's the PR I sent for this
I think this is what causes #17, though I'm not sure it is the only cause. I got it while sending a React element in an action payload, and React elements have a
$$typeof: Symbol.for('react.element')
property