Parse unknown metadata and write metadata #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessa0
force-pushed
the
jessa0/unknown-meta
branch
from
d72c27a
to
5f61fd2
Compare
|
Thanks again @jessa0. I will take a look at this soon. |
alfg
reviewed
Jan 21, 2023
| #[derive(Debug, Clone, PartialEq, Eq, Serialize)] | ||
| #[serde(tag = "hdlr")] | ||
| #[serde(rename_all = "lowercase")] | ||
| pub enum MetaBox { |
There was a problem hiding this comment.
Should we also implement the Mp4Box trait for meta (and child boxes)? So I can access mp4.moov.meta for example.
There was a problem hiding this comment.
good idea. i already had written another commit 669edcf to be able to write meta and udta boxes which adds these implementations, but was waiting for this PR to merge before opening another. I'll just push it to this branch.
jessa0
changed the title
|
Thanks again @jessa0. Sorry for the delay. I will review and try this out soon. |
|
Looks good. Thank you @jessa0! |
jprochazk
pushed a commit
to jprochazk/mp4
that referenced
this pull request
Sep 18, 2024
* validate meta box handler type, parse meta with unknown handlers * parse meta in moov and trak position * write meta and udta * fix clippy nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The meta box is very open-ended, leaving itself open to extension by future specs. This PR:
Hdlrboxas required by the spec for the meta boxmdir(as seen in `big_buck_bunny_metadata.m4v)MetaBoxinto an enum, to allow for other handlers in the future (like requested in question: MOV Quicktime and MP4 metadata #66)MetaBoxin more positions as per the spec