New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more error formatting for REST responses #27

Merged

algochoi merged 1 commit into algochoi:v2-goal-migration from jasonpaulos:rest-client-error-extraction

Nov 3, 2022

jasonpaulos commented Nov 3, 2022

This PR has the following benefits:

Error messages are no longer encased in {"message":"..."}
HTML-escaped characters are now decoded for all error messages that adhere to generatedV2.ErrorResponse

Both of these changes make v2 algod responses behave more like v1 responses.


          Add more error formatting for REST responses

8fa59f7

jasonpaulos mentioned this pull request

algod: Migrate internal uses of v1 algod API to v2 algorand/go-algorand#4684

Merged

3 tasks

algochoi approved these changes

View reviewed changes

Owner

algochoi left a comment

Thanks a lot! Can confirm the changes work with local tests as expected 👍

algochoi merged commit e1e2a4b into algochoi:v2-goal-migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet