From 9a34596be2bab9c14ec63c6c51bb66975b996274 Mon Sep 17 00:00:00 2001 From: Dishant Kapoor Date: Tue, 16 Jan 2024 17:53:42 +0530 Subject: [PATCH 1/3] algolia #1183 --- packages/autocomplete-js/src/createAutocompleteDom.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/autocomplete-js/src/createAutocompleteDom.ts b/packages/autocomplete-js/src/createAutocompleteDom.ts index 79fdb1264..bbcec3c3d 100644 --- a/packages/autocomplete-js/src/createAutocompleteDom.ts +++ b/packages/autocomplete-js/src/createAutocompleteDom.ts @@ -161,6 +161,7 @@ export function createAutocompleteDom({ const detachedSearchButton = createDomElement('button', { type: 'button', class: classNames.detachedSearchButton, + title: 'Search', onClick() { setIsModalOpen(true); }, @@ -172,6 +173,7 @@ export function createAutocompleteDom({ }); const detachedCancelButton = createDomElement('button', { type: 'button', + title: 'Cancel', class: classNames.detachedCancelButton, textContent: translations.detachedCancelButtonText, // Prevent `onTouchStart` from closing the panel From 5adba56ebc82f42a784d35b878045acde26f9d7c Mon Sep 17 00:00:00 2001 From: Dishant Kapoor Date: Tue, 6 Feb 2024 14:07:49 +0530 Subject: [PATCH 2/3] algolia #1183 --- packages/autocomplete-js/src/createAutocompleteDom.ts | 3 ++- .../autocomplete-shared/src/js/AutocompleteTranslations.ts | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/autocomplete-js/src/createAutocompleteDom.ts b/packages/autocomplete-js/src/createAutocompleteDom.ts index bbcec3c3d..ca950dbf0 100644 --- a/packages/autocomplete-js/src/createAutocompleteDom.ts +++ b/packages/autocomplete-js/src/createAutocompleteDom.ts @@ -161,7 +161,8 @@ export function createAutocompleteDom({ const detachedSearchButton = createDomElement('button', { type: 'button', class: classNames.detachedSearchButton, - title: 'Search', + title: translations.detachedSearchButtonTitle, + id: labelProps.id, onClick() { setIsModalOpen(true); }, diff --git a/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts b/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts index f42c53645..97609f40b 100644 --- a/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts +++ b/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts @@ -2,4 +2,5 @@ export type AutocompleteTranslations = { detachedCancelButtonText: string; clearButtonTitle: string; submitButtonTitle: string; + detachedSearchButtonTitle:string; }; From 12b3d544752cd00af41747de29b699880df3210d Mon Sep 17 00:00:00 2001 From: Dishant Kapoor Date: Tue, 6 Feb 2024 19:56:42 +0530 Subject: [PATCH 3/3] algolia #1234 --- packages/autocomplete-js/src/createAutocompleteDom.ts | 1 - packages/autocomplete-js/src/getDefaultOptions.ts | 1 + packages/autocomplete-shared/src/js/AutocompleteTranslations.ts | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/autocomplete-js/src/createAutocompleteDom.ts b/packages/autocomplete-js/src/createAutocompleteDom.ts index ca950dbf0..130c0b4bb 100644 --- a/packages/autocomplete-js/src/createAutocompleteDom.ts +++ b/packages/autocomplete-js/src/createAutocompleteDom.ts @@ -174,7 +174,6 @@ export function createAutocompleteDom({ }); const detachedCancelButton = createDomElement('button', { type: 'button', - title: 'Cancel', class: classNames.detachedCancelButton, textContent: translations.detachedCancelButtonText, // Prevent `onTouchStart` from closing the panel diff --git a/packages/autocomplete-js/src/getDefaultOptions.ts b/packages/autocomplete-js/src/getDefaultOptions.ts index 4958302b2..d4319d140 100644 --- a/packages/autocomplete-js/src/getDefaultOptions.ts +++ b/packages/autocomplete-js/src/getDefaultOptions.ts @@ -138,6 +138,7 @@ export function getDefaultOptions( const defaultTranslations: AutocompleteTranslations = { clearButtonTitle: 'Clear', detachedCancelButtonText: 'Cancel', + detachedSearchButtonTitle: 'Search', submitButtonTitle: 'Submit', }; diff --git a/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts b/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts index 97609f40b..1847c9b76 100644 --- a/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts +++ b/packages/autocomplete-shared/src/js/AutocompleteTranslations.ts @@ -2,5 +2,5 @@ export type AutocompleteTranslations = { detachedCancelButtonText: string; clearButtonTitle: string; submitButtonTitle: string; - detachedSearchButtonTitle:string; + detachedSearchButtonTitle: string; };