-
Notifications
You must be signed in to change notification settings - Fork 85
forwardRef fix for displayName #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. Just a first quick review for now. I will have another look later
package.json
Outdated
@@ -68,6 +68,7 @@ | |||
"prettier": "1.18.2", | |||
"react": "16.11.0", | |||
"react-dom": "16.11.0", | |||
"react-is": "^16.11.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are using Yarn as package manager. You need to use it to add the dependencies yarn install react-is@^16.11.0
. It will upgrade the yarn.lock
file accordingly and allow the CI to run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the pr with the lock file.
Thanks for pointing out.
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Headed over here for this fix. Thanks @roedit. I think the commit messages just need correctly formatting. |
What's the status of this PR? We're running into this issue ourselves and would love a release of this one! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It need to be rebased on master. Thanks for this change!
Hi,
I added a fix for <[object Object] /> when using forwardRef
Regards