Skip to content

forwardRef fix for displayName #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

Conversation

roedit
Copy link

@roedit roedit commented Nov 7, 2019

Hi,
I added a fix for <[object Object] /> when using forwardRef

Regards

@ghost
Copy link

ghost commented Nov 7, 2019

There were the following issues with this Pull Request

  • Commit: a965472
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 549bf5e
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

Copy link
Collaborator

@armandabric armandabric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. Just a first quick review for now. I will have another look later

package.json Outdated
@@ -68,6 +68,7 @@
"prettier": "1.18.2",
"react": "16.11.0",
"react-dom": "16.11.0",
"react-is": "^16.11.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using Yarn as package manager. You need to use it to add the dependencies yarn install react-is@^16.11.0. It will upgrade the yarn.lock file accordingly and allow the CI to run.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the pr with the lock file.
Thanks for pointing out.

@ghost
Copy link

ghost commented Nov 8, 2019

There were the following issues with this Pull Request

  • Commit: a965472
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 549bf5e
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 2a6994f
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@HHogg
Copy link
Contributor

HHogg commented Jan 10, 2020

Headed over here for this fix. Thanks @roedit. I think the commit messages just need correctly formatting.

@kate-hall
Copy link

What's the status of this PR? We're running into this issue ourselves and would love a release of this one!

Copy link
Collaborator

@armandabric armandabric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It need to be rebased on master. Thanks for this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants