-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CICD: Macos11 support #4399
CICD: Macos11 support #4399
Conversation
Support for MacOS 11
Codecov Report
@@ Coverage Diff @@
## master #4399 +/- ##
==========================================
+ Coverage 55.19% 55.25% +0.05%
==========================================
Files 398 398
Lines 50165 50165
==========================================
+ Hits 27689 27717 +28
+ Misses 20159 20140 -19
+ Partials 2317 2308 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -673,7 +673,7 @@ jobs: | |||
- run: | |||
no_output_timeout: 45m | |||
command: | | |||
#export PATH=$(echo "$PATH" | sed -e 's|:/home/circleci/\.go_workspace/bin||g' | sed -e 's|:/usr/local/go/bin||g') | |||
# export PATH=$(echo "$PATH" | sed -e 's|:/home/circleci/\.go_workspace/bin||g' | sed -e 's|:/usr/local/go/bin||g') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because ide added a space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are asking why the command is there, i don't know. I think we were trying to cut out homebrew path and golang path from path env var. But since it works without this for now, maybe it's not needed at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we don't currently run that workflow (windows build) I can't say for sure, and don't want to remove it until we test if we need it or not.
Tested by running in circleci: https://app.circleci.com/pipelines/github/algorand/go-algorand/8694/workflows/2e801391-7eaa-4f5f-a522-9ad05b49326c