lint: add unnecessary conversions linter to automated PR advice #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4710 +/- ##
==========================================
- Coverage 54.49% 54.42% -0.07%
==========================================
Files 407 407
Lines 52389 52389
==========================================
- Hits 28548 28513 -35
- Misses 21455 21481 +26
- Partials 2386 2395 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michaeldiamant
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
@cce Seems reasonable to me.
I'd also be on-board to make unnecessary conversions an error. It's possible an unnecessary conversion becomes necessary through various future changes. Depending on the situation, a conversion may not be desired behavior.
|
Sure! If you want to do that it is a nice soothing sudoku-like game to go in and fix them all and get them lint clean in another PR.. I had intended to use the warning-level linter for introducing potentially controversial linter opinions like this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds the unconvert linter to the .golangci-warnings.yml configuration, which is used by Github Actions & reviewdog to provide automated advice on new lines added that provides linter output, but does not block a PR.
Test Plan
No change besides linter settings.