Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make ledger tests ~20 sec faster #4739

Merged
merged 3 commits into from
Nov 3, 2022

Conversation

algorandskiy
Copy link
Contributor

Summary

  1. Make TestCatchpointFileBalancesChunkEncoding smaller. It does not check limits now but only encode-decode trip.
  2. Make TestLedgerMigrateV6ShrinkDeltas smaller.

Test Plan

These are tests

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #4739 (241aa21) into master (fa77937) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4739      +/-   ##
==========================================
- Coverage   54.62%   54.57%   -0.05%     
==========================================
  Files         414      414              
  Lines       53514    53514              
==========================================
- Hits        29231    29207      -24     
- Misses      21860    21881      +21     
- Partials     2423     2426       +3     
Impacted Files Coverage Δ
ledger/catchpointwriter.go 59.67% <ø> (ø)
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) ⬇️
agreement/cryptoVerifier.go 67.60% <0.00%> (-2.12%) ⬇️
agreement/proposalManager.go 96.07% <0.00%> (-1.97%) ⬇️
network/wsPeer.go 66.50% <0.00%> (-1.95%) ⬇️
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) ⬇️
cmd/tealdbg/debugger.go 72.69% <0.00%> (-0.81%) ⬇️
network/wsNetwork.go 65.34% <0.00%> (-0.37%) ⬇️
catchup/service.go 68.88% <0.00%> (ø)
ledger/testing/randomAccounts.go 56.61% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@cce cce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added a comment to help understand better what are the types inside the catchpoint chunks

@algorandskiy algorandskiy merged commit 3701d29 into algorand:master Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants