-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcs: simplify API for BlockService to handle multiple HTTP paths #5718
Merged
algorandskiy
merged 9 commits into
algorand:master
from
zeldovich:register-http-handler
Jul 26, 2024
Merged
rpcs: simplify API for BlockService to handle multiple HTTP paths #5718
algorandskiy
merged 9 commits into
algorand:master
from
zeldovich:register-http-handler
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a helper BlockService.RegisterHandlers() that registers handlers for multiple HTTP paths, in preparation for adding more handlers.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5718 +/- ##
==========================================
- Coverage 56.29% 56.27% -0.02%
==========================================
Files 488 488
Lines 69581 69595 +14
==========================================
- Hits 39172 39167 -5
- Misses 27752 27771 +19
Partials 2657 2657 ☔ View full report in Codecov by Sentry. |
jasonpaulos
reviewed
Jul 23, 2024
jasonpaulos
approved these changes
Jul 26, 2024
algorandskiy
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a helper
BlockService.RegisterHandlers()
that registers handlers for multiple HTTP paths, and aRegisterHTTPHandlerFunc()
method toGossipNode
that can register handler functions in addition to handler objects, in preparation for adding more handlers (specifically, fetching a state proof).