Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcs: simplify API for BlockService to handle multiple HTTP paths #5718

Merged
merged 9 commits into from
Jul 26, 2024

Conversation

zeldovich
Copy link
Contributor

Add a helper BlockService.RegisterHandlers() that registers handlers for multiple HTTP paths, and a RegisterHTTPHandlerFunc() method to GossipNode that can register handler functions in addition to handler objects, in preparation for adding more handlers (specifically, fetching a state proof).

Add a helper BlockService.RegisterHandlers() that registers handlers for
multiple HTTP paths, in preparation for adding more handlers.
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 56.27%. Comparing base (75bb6a9) to head (cddb78e).
Report is 3 commits behind head on master.

Files Patch % Lines
network/p2p/http.go 0.00% 5 Missing ⚠️
network/hybridNetwork.go 0.00% 3 Missing ⚠️
network/p2pNetwork.go 0.00% 2 Missing ⚠️
network/wsNetwork.go 0.00% 2 Missing ⚠️
rpcs/blockService.go 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5718      +/-   ##
==========================================
- Coverage   56.29%   56.27%   -0.02%     
==========================================
  Files         488      488              
  Lines       69581    69595      +14     
==========================================
- Hits        39172    39167       -5     
- Misses      27752    27771      +19     
  Partials     2657     2657              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rpcs/blockService.go Outdated Show resolved Hide resolved
@algorandskiy algorandskiy merged commit edda2ee into algorand:master Jul 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants