-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catchup: state-proof-based catchup #5720
Draft
zeldovich
wants to merge
6
commits into
algorand:nickolai/state-proof-catchup-base
Choose a base branch
from
zeldovich:state-proof-catchup
base: nickolai/state-proof-catchup-base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
catchup: state-proof-based catchup #5720
zeldovich
wants to merge
6
commits into
algorand:nickolai/state-proof-catchup-base
from
zeldovich:state-proof-catchup
+2,343
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for catchup to use state proofs to validate new blocks. The main changes are: - The catchup service now has a state proof fetcher, whose job is to retrieve state proofs for rounds beyond the current ledger state. These state proofs are stored in an sqlite DB, since there might be many state proofs that we need to fetch. - The catchup service exposes a way to set trusted "renaissance" parameters for authenticating the initial state proofs, for cases when we can't use state proofs from the genesis block (like the situation we have on mainnet now). - The BlockService HTTP interface adds support for retrieving a state proof, and for getting a light block header proof instead of a cert when retrieving a block. - The catchup service uses state proofs, if possible, to authenticate new blocks, in lieu of agreement certificates. The catchup service is backwards-compatible: if it requests a state proof from the BlockService, but receives an agreement certificate instead (e.g., because the BlockService has not been upgraded with the above changes), the catchup service will validate the certificate instead. - The config file has additional fields to optionally specify the renaissance catchup parameters, to allow catchup to start validating state proofs from some (trusted through out-of-band channels) block. It may be a good idea, for performance, to pre-compute the state proofs and distribute them in a single file, rather than asking many relays to find the state proofs on-demand. This is not done yet, because it largely depends on how we would want to distribute these bundled state proofs. It should be reasonably straightforward to feed a bundle of state proofs into the stateProofFetcher.
zeldovich
force-pushed
the
state-proof-catchup
branch
from
August 31, 2023 03:03
9d4edc4
to
d4bf217
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nickolai/state-proof-catchup-base #5720 +/- ##
=====================================================================
+ Coverage 46.15% 53.33% +7.17%
=====================================================================
Files 473 474 +1
Lines 66330 66815 +485
=====================================================================
+ Hits 30616 35635 +5019
+ Misses 33095 28639 -4456
+ Partials 2619 2541 -78 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for catchup to use state proofs to validate new blocks.
The main changes are:
The catchup service now has a state proof fetcher, whose job is to retrieve state proofs for rounds beyond the current ledger state. These state proofs are stored in an sqlite DB, since there might be many state proofs that we need to fetch.
The catchup service exposes a way to set trusted "renaissance" parameters for authenticating the initial state proofs, for cases when we can't use state proofs from the genesis block (like the situation we have on mainnet now).
The BlockService HTTP interface adds support for retrieving a state proof, and for getting a light block header proof instead of a cert when retrieving a block.
The catchup service uses state proofs, if possible, to authenticate new blocks, in lieu of agreement certificates. The catchup service is backwards-compatible: if it requests a state proof from the BlockService, but receives an agreement certificate instead (e.g., because the BlockService has not been upgraded with the above changes), the catchup service will validate the certificate instead.
The config file has additional fields to optionally specify the renaissance catchup parameters, to allow catchup to start validating state proofs from some (trusted through out-of-band channels) block.
It may be a good idea, for performance, to pre-compute the state proofs and distribute them in a single file, rather than asking many relays to find the state proofs on-demand. This is not done yet, because it largely depends on how we would want to distribute these bundled state proofs. It should be reasonably straightforward to feed a bundle of state proofs into the stateProofFetcher.
This is a somewhat large PR; I tried to factor out some independent pieces from it (the still-open ones are PRs #5663, #5703, #5718), but unfortunately I couldn't find other substantial pieces to meaningfully split out on their own. This PR is against a temporary branch (
nickolai/state-proof-catchup-base
) that already has the above PRs applied, so that they don't show up in the code diff for this PR.