Skip to content

Conversation

@cce
Copy link
Contributor

@cce cce commented Apr 2, 2025

Summary

We don't need to lower the current RLIMIT_NOFILE limit, which we were doing before. This ensures that we only raise it if needed. It also adds a constant number of additional FDs to the requested limit if P2P is enabled. This constant is arbitrary, we could decide to adjust it, or make it a separate configuration value.

Test Plan

Existing tests should pass.

@cce cce added the Enhancement label Apr 2, 2025
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 51.61%. Comparing base (5b9eee2) to head (3259737).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
util/util.go 0.00% 9 Missing ⚠️
daemon/algod/server.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6289      +/-   ##
==========================================
- Coverage   51.62%   51.61%   -0.02%     
==========================================
  Files         647      647              
  Lines       86882    86893      +11     
==========================================
- Hits        44855    44847       -8     
- Misses      39166    39182      +16     
- Partials     2861     2864       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cce cce marked this pull request as ready for review April 3, 2025 16:08
@cce cce force-pushed the set-rlimit-cur branch from a6c52d6 to 3259737 Compare April 3, 2025 16:17
@algorandskiy algorandskiy requested review from gmalouf and jannotti April 8, 2025 15:03
@cce cce requested a review from Copilot April 9, 2025 15:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

@cce cce merged commit 5eaeb44 into algorand:master Apr 9, 2025
19 checks passed
@cce cce deleted the set-rlimit-cur branch April 9, 2025 15:25
cce added a commit to cce/go-algorand that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants