-
Notifications
You must be signed in to change notification settings - Fork 519
util: only set rlimit if needed #6289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6289 +/- ##
==========================================
- Coverage 51.62% 51.61% -0.02%
==========================================
Files 647 647
Lines 86882 86893 +11
==========================================
- Hits 44855 44847 -8
- Misses 39166 39182 +16
- Partials 2861 2864 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Summary
We don't need to lower the current RLIMIT_NOFILE limit, which we were doing before. This ensures that we only raise it if needed. It also adds a constant number of additional FDs to the requested limit if P2P is enabled. This constant is arbitrary, we could decide to adjust it, or make it a separate configuration value.
Test Plan
Existing tests should pass.