-
Notifications
You must be signed in to change notification settings - Fork 519
ledger: fix exceeding offline rows in online accounts table #6295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
onetechnical
merged 3 commits into
algorand:master
from
algorandskiy:pavel/online-acct-exceed-offline-rows
Apr 8, 2025
Merged
ledger: fix exceeding offline rows in online accounts table #6295
onetechnical
merged 3 commits into
algorand:master
from
algorandskiy:pavel/online-acct-exceed-offline-rows
Apr 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cce
reviewed
Apr 7, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6295 +/- ##
==========================================
+ Coverage 51.69% 51.70% +0.01%
==========================================
Files 649 649
Lines 86858 86860 +2
==========================================
+ Hits 44901 44915 +14
+ Misses 39094 39089 -5
+ Partials 2863 2856 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jannotti
previously approved these changes
Apr 7, 2025
jannotti
previously approved these changes
Apr 7, 2025
cce
reviewed
Apr 8, 2025
cce
approved these changes
Apr 8, 2025
jannotti
approved these changes
Apr 8, 2025
onetechnical
pushed a commit
to onetechnical/go-algorand
that referenced
this pull request
Apr 8, 2025
This was referenced Apr 8, 2025
This was referenced May 15, 2025
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After adding online accounts table data into catchpoint files (see #6177), we figured out the table might have some exceed rows in the following cases:
Fixed by comparing the voting data for existing and new accounts when updating the ledger db.
Test Plan
Added a new unit test exercising both cases.