Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs by providing root requirements.txt #332

Merged
merged 3 commits into from
May 4, 2022
Merged

Conversation

michaeldiamant
Copy link
Contributor

Attempts to fix docs since v1.13.0 by supplying missing dependencies.

v1.13.0 readthedocs build (https://readthedocs.org/api/v2/build/16801913.txt) shows errors (that don't fail the build) for a missing msgpack dependency:

WARNING: autodoc: failed to import module 'abi.address_type' from module 'algosdk'; the following exception was raised:
No module named 'msgpack'

These errors do not appear in v1.12.0 build: https://readthedocs.org/api/v2/build/16801915.txt.

@michaeldiamant michaeldiamant marked this pull request as ready for review May 4, 2022 17:10
@michaeldiamant michaeldiamant requested review from algojohnlee and onetechnical and removed request for algojohnlee May 4, 2022 17:11
@michaeldiamant
Copy link
Contributor Author

With @onetechnical, we visually confirmed the docs generated as intended by temporarily marking fix_docs as an active version in readthedocs. Doing so, allowed us to see the generated docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants