Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ABI Strings #278
ABI Strings #278
Changes from all commits
efbe1e5
7db17ca
4055424
12a36a6
af7967d
3e7fdfd
41ab811
1c22d14
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really work, since
StaticArray.__init__
expects the TypeSpec of the elements and the length of the array, and internally it creates aStaticArrayTypeSpec
from those. So with this current behavior, any subclass ofStaticArray
will never be able to change the fact that its TypeSpec is aStaticArrayTypeSpec
.Probably you should modify
StaticArray.__init__
to take aStaticArrayTypeSpec
directly, that wayAddress
can pass in anAddressTypeSpec
. A similar thing needs to happen withDynamicArray
as well, and maybe for consistency it should happen withTuple
too?