-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade go kafka client sarama version v1.42.2 to v1.43.3 #1772
base: main
Are you sure you want to change the base?
Conversation
mengfanwei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@WillMeng For this client upgrade, also change the default Additionally, modify the default size description for |
Thanks reply. |
Yes, it needs to be updated, Kafka upgrades will not be compatible. |
Sorry, I reviewed the code about Sarama 1.43.3, it currently only supports Kafka 3.6.0 and does not support Kafka 3.8.0. We used kafka version 3.8.0, ilogtail kafka config The Kafka protocol version is not strongly associated with the Kafka release version. The Kafka protocol version primarily represents the message protocol version supported by Kafka. In fact, current high-version Kafka instances all support Kafka protocol version 2.1.0, and future Kafka 4.0 will also support Kafka protocol version 2.1.0. As long as the Kafka protocol version does not exceed the release version of Kafka, it should work correctly. |
@WillMeng ilogtail flusher kafka v2之前默认设置的协议版本号是1.0.0,高版本的kafka已经声明了不再支持2.1.0以下的message协议版本,如果配置写入高版本的kafka是将Version指定kafka message version为2.1.0以上的即可。因此本次升级客户端可以修改下设置的默认值为2.1.0, 这样高于2.1.0以上的kafka不配置Version默认也是可以正常用的。 |
I have updated the doc, please review it, thanks |
可以麻烦您把主干先merge一下吗?让测试跑通就可以合入了 |
可以先rebase下这个pr分支,然后使用再基于main分支rebase下 |
support kafka version 3.8.0
issue #1767