build: fix esBuild only emitting esm format #540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorkie
reviewed
Sep 1, 2020
| "clean": "rm -rf ./dist && rm -rf tsconfig.tsbuildinfo", | ||
| "dev-compile": "esbuild ./src/*.ts ./src/**/*.ts --tsconfig=tsconfig.json --outdir=dist && sh setup.sh", | ||
| "dev-compile": "esbuild ./src/*.ts ./src/**/*.ts --tsconfig=tsconfig.json --outdir=dist && npm run dev-trans && sh setup.sh", |
There was a problem hiding this comment.
Shall we have a universal script for wrapping the dev-trans and dev-compile?
There was a problem hiding this comment.
For now, this dev-trans is just a temporary workaround. We will get rid of it eventually. In this case, I don't think we need to have a universal script.
|
@WenheLI The current script looks too complicated, may I ask you to simplify this? |
esBuild now support directly exporting packages to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the #520 which only generates
esmformat for nodejs.To make a temporary workaround, I imported
babelto transformesmtocjs.For the build performance, despite using
esbuild+babel, the speed is still out-performtsc:Note: since
esbuildomitsinterfacein ts, we need to operate a regularbuildprior todev-buildto avoid missinginterfaceonly files.In the long run, I will add try to add the support of
esm2cjstransforming foresBuildto avoid the babel overhead.