From 17b8e6c599be7cf8d416e6c1a76b8bd67aa89aa8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Candice=20Bent=C3=A9jac?= <candice.bentejac@gmail.com>
Date: Thu, 20 Jul 2023 10:54:45 +0200
Subject: [PATCH] brackets : a group of size 0 was always created

---
 src/aliceVision/hdr/brackets.cpp | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/aliceVision/hdr/brackets.cpp b/src/aliceVision/hdr/brackets.cpp
index aeecd14272..edf88e9ded 100644
--- a/src/aliceVision/hdr/brackets.cpp
+++ b/src/aliceVision/hdr/brackets.cpp
@@ -11,6 +11,8 @@ namespace hdr {
 
 bool estimateBracketsFromSfmData(std::vector<std::vector<std::shared_ptr<sfmData::View>>>& groups, const sfmData::SfMData& sfmData, size_t countBrackets)
 {
+    groups.clear();
+
     size_t countImages = sfmData.getViews().size();
     if(countImages == 0)
     {
@@ -53,7 +55,7 @@ bool estimateBracketsFromSfmData(std::vector<std::vector<std::shared_ptr<sfmData
     }
     
     std::vector<std::shared_ptr<sfmData::View>> group;
-    double lastExposure = std::numeric_limits<double>::max();
+    double lastExposure = std::numeric_limits<double>::min();
     for(auto& view : viewsOrderedByName)
     {
         if (countBrackets > 0)
@@ -110,6 +112,12 @@ bool estimateBracketsFromSfmData(std::vector<std::vector<std::shared_ptr<sfmData
             maxSize = item.second;
             bestBracketCount = item.first;
         }
+        else if (item.second == maxSize && item.first > bestBracketCount)
+        {
+            //If two brackets size have the same vote number, 
+            //Keep the larger one (Just to avoid keeping only the outlier)
+            bestBracketCount = item.first;
+        }
     }
 
     //Only keep groups with majority bracket size