Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libgnatdoc and liblal_refactor 24.0.0 #1227

Merged

Conversation

Fabien-Chouteau
Copy link
Member

No description provided.

@Fabien-Chouteau
Copy link
Member Author

Ping @reznikmm

@Fabien-Chouteau
Copy link
Member Author

Errors on Windows seem to be unrelated to the crates. We have to work on improving stability here.

stderr: Failed Outcome because of exception: 
stderr: file "C:\Users\runneradmin\AppData\Local\alire\settings\indexes\community\repo\.git\objects\pack\pack-d4da5daa0c2ac681f11001baa49d7e93695d5a08.idx" could not be deleted
stderr: raised ADA.IO_EXCEPTIONS.USE_ERROR : file "C:\Users\runneradmin\AppData\Local\alire\settings\indexes\community\repo\.git\objects\pack\pack-d4da5daa0c2ac681f11001baa49d7e93695d5a08.idx" could not be deleted
stderr: ADA.IO_EXCEPTIONS.USE_ERROR
stderr: copy of "C:\Users\runneradmin\AppData\Local\alire\cache\releases\libgpr2_24.0.0_eda3c693\testsuite\tests\load-preinstalled\fake-ada-x86_64-wrs-vxworks7\x86_64-wrs-vxworks7\rtp\share\gpr\preinstalled.g
stderr: raised ADA.IO_EXCEPTIONS.USE_ERROR : copy of "C:\Users\runneradmin\AppData\Local\alire\cache\releases\libgpr2_24.0.0_eda3c693\testsuite\tests\load-preinstalled\fake-ada-x86_64-wrs-vxworks7\x86_64-wrs-vxworks7\rtp\share\gpr\preinstalled.g

@mosteo
Copy link
Member

mosteo commented Sep 19, 2024

The fact that both the old and new implementations for syncing, which are quite different, fail on gpr2, makes me suspect that there is indeed some specific trouble on Windows not just in the CI setup.

I'll check ASAP, but this week I'm on a work trip so time is scarce.

@mosteo
Copy link
Member

mosteo commented Sep 20, 2024

It turns out it was too long paths.

@mosteo mosteo merged commit fb7f72b into alire-project:stable-1.3.0 Sep 20, 2024
13 of 14 checks passed
@Fabien-Chouteau Fabien-Chouteau deleted the missing_adacore_24_libs branch September 20, 2024 09:50
@Fabien-Chouteau
Copy link
Member Author

It turns out it was too long paths.

Is there a way for us to configure this in the runners?

@mosteo
Copy link
Member

mosteo commented Sep 20, 2024

What I did is relocating the cache to /tmp using alr settings before the test (in the alire-index-checks repo). Is that what you mean?

I'm also thinking that the long hashes for the build dirs could be truncated (with clash detection); I doubt the whole hash is ever needed.

@Fabien-Chouteau
Copy link
Member Author

There are options to enable long-path support:

Not sure if the the git option is useful.

I'm also thinking that the long hashes for the build dirs could be truncated (with clash detection); I doubt the whole hash is ever needed.

Users will encounter this problem on their machine, so we should find a robust solution.

Also I spotted this: https://stackoverflow.com/questions/21194530/what-does-mean-when-prepended-to-a-file-path
Not sure if it's applicable to us.

@mosteo
Copy link
Member

mosteo commented Sep 23, 2024

Not sure if the the git option is useful.

It says in the 2nd issue you linked to that it causes issues with, among others, msys. I might at least try it to see what happens.

Also I spotted this: https://stackoverflow.com/questions/21194530/what-does-mean-when-prepended-to-a-file-path
Not sure if it's applicable to us.

In this particular case, the error happened when trying to sync from the download folder to the build folder (which is 64 chars longer approx), so it might well apply. It wouldn't make us safe from the error happening during checkout by git itself, unless we can safely enable longpaths in git.

I'll create an issue to track this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants