Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmaintained and vulnerable dependency #80

Open
losuler opened this issue Mar 2, 2021 · 0 comments
Open

Unmaintained and vulnerable dependency #80

losuler opened this issue Mar 2, 2021 · 0 comments

Comments

@losuler
Copy link

losuler commented Mar 2, 2021

The dependency satori/go.uuid is no longer maintained satori/go.uuid#84 and it's current pinning on v1.2.0 suffers from this vulnerability satori/go.uuid#73.

Suggested fixes include either pinning the latest commit on the master branch of satori/go.uuid where this issue has been fixed satori/go.uuid@75cca53 or move to a maintained replacement such as gofrs/uuid or google/uuid, which also resolves a number of other bugs.

The only change besides changing the pinning would be this line:

--- tunnel/api.go.orig	2021-03-02 16:37:50.890286864 +1100
+++ tunnel/api.go	2021-03-02 16:38:28.083334608 +1100
@@ -163,7 +163,7 @@ func (api *TunnelApi) doRequestInternal(
 		hreq.Header.Set(xOtsHeaderStsToken, api.securityToken)
 		otshead.set(xOtsHeaderStsToken, api.securityToken)
 	}
-	traceId := uuid.NewV4()
+	traceId := uuid.Must(uuid.NewV4())
 	hreq.Header.Set(xOtsHeaderTraceID, traceId.String())
 	otshead.set(xOtsHeaderTraceID, traceId.String())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant