Fix tests & switch debug_assert_eq! to assert_eq!

The reason for the switch to `assert_eq!` is because in both cases there was an
important mutation:

```rust
debug_assert_eq!(sout.pop(), Some(b'\''));
```

That `pop()` was not being called in release builds (try running `cargo test
--release`) and it was affecting correctness.

README.md

@@ -10,7 +10,7 @@ Inspired by the Haskell [shell-escape][] package, which is the most
 comprehensive implementation of shell escaping I've yet seen.
 
 For now this package implements escaping for `/bin/sh`-like shells, [GNU
-Bash][gnu-bash] and [fish][]. 
+Bash][gnu-bash] and [fish][].
 Please read the documentation for each module to learn about some limitations
 and caveats.
 
@@ -30,14 +30,14 @@ assert_eq!(Sh::quote("foobar"), b"foobar");
 assert_eq!(Fish::quote("foobar"), b"foobar");
 assert_eq!(Bash::quote("foo bar"), b"$'foo bar'");
 assert_eq!(Sh::quote("foo bar"), b"'foo bar'");
-assert_eq!(Fish::quote("foo bar"), b"'foobar'");
+assert_eq!(Fish::quote("foo bar"), b"'foo bar'");
 ```
 
 It's also possible to use the extension trait [`QuoteRefExt`] which provides a
 [`quoted`] function:
 
 ```rust
-use shell_quote::{Bash, Sh, QuoteRefExt};
+use shell_quote::{Bash, Sh, Fish, QuoteRefExt};
 let quoted: Vec<u8> = "foo bar".quoted(Bash);
 assert_eq!(quoted, b"$'foo bar'");
 let quoted: Vec<u8> = "foo bar".quoted(Sh);

src/fish.rs

@@ -33,7 +33,7 @@ impl Fish {
     /// ```
     /// # use shell_quote::{Fish, Quoter};
     /// assert_eq!(Fish::quote("foobar"), b"foobar");
-    /// assert_eq!(Fish::quote("foo 'bar"), b"'foo \'bar'");
+    /// assert_eq!(Fish::quote("foo 'bar"), b"'foo \\'bar'");
     /// ```
     pub fn quote<'a, S: ?Sized + Into<Quotable<'a>>>(s: S) -> Vec<u8> {
         let sin: Quotable<'a> = s.into();
@@ -60,7 +60,7 @@ impl Fish {
     /// Fish::quote_into("foobar", &mut buf);
     /// buf.push(b' ');  // Add a space.
     /// Fish::quote_into("foo 'bar", &mut buf);
-    /// assert_eq!(buf, b"foobar 'foo \'bar'");
+    /// assert_eq!(buf, b"foobar 'foo \\'bar'");
     /// ```
     ///
     pub fn quote_into<'a, S: ?Sized + Into<Quotable<'a>>>(s: S, sout: &mut Vec<u8>) {
@@ -114,7 +114,7 @@ fn escape_chars(esc: Vec<Char>, sout: &mut Vec<u8>) {
                 is_there_char_after_last_single_quote = false;
             } else {
                 // Pop the useless single quote
-                debug_assert_eq!(sout.pop(), Some(b'\''));
+                assert_eq!(sout.pop(), Some(b'\''));
                 sout.extend(literal);
                 sout.push(b'\'');
                 is_there_char_after_last_single_quote = false;
@@ -153,6 +153,6 @@ fn escape_chars(esc: Vec<Char>, sout: &mut Vec<u8>) {
         sout.push(b'\'');
     } else {
         // Pop the useless single quote
-        debug_assert_eq!(sout.pop(), Some(b'\''));
+        assert_eq!(sout.pop(), Some(b'\''));
     }
 }