Some performance tweaks #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating an accurate figure is complex. Guessing is likely to be wrong and result in a reallocation anyway. For now, punt on this and rely on the already reasonable reallocation strategy of `Vec`.
It was 2-3 times slower. Interesting experiment though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some experiments to try and improve performance, including adding a new UTF-8 benchmark for all quoters. Two big lessons:
Vecdo its thing. In the end, I went with simpler-is-better and removed the pre-calculation code. If memory usage becomes a priority then it might be worth revisiting this.Vecis hard. I created a customChaindata type to avoid reallocations – which I didn't optimise much, to be fair – but it was 2+ times slower that lettingVecfollow its own reallocation strategy.