chore: replace ExitV1 with WithdrawalRequest
#672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EIP-7002 has been changed to work with EIP-7685, so the exit type no longer exists and is instead a `WithdrawalRequest` object. In the engine API spec this is called `WithdrawalRequestV1`, which is why it is re-exported as such from `alloy-eips`
onbjerg
requested review from
DaniPopes,
gakonst,
mattsse,
prestwich and
Evalir
as code owners
mattsse
approved these changes
May 3, 2024
3 tasks
ben186
pushed a commit
to ben186/alloy
that referenced
this pull request
Jul 27, 2024
* chore: replace `ExitV1` with `WithdrawalRequest` EIP-7002 has been changed to work with EIP-7685, so the exit type no longer exists and is instead a `WithdrawalRequest` object. In the engine API spec this is called `WithdrawalRequestV1`, which is why it is re-exported as such from `alloy-eips` * fix: cfg attr for serde * chore: correct field name * chore: cfg attr _-_ * chore: delete `exit` module (unused)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
EIP-7002 has been changed to work with EIP-7685, so the exit type no longer exists and is instead a
WithdrawalRequestobject.In the engine API spec this is called
WithdrawalRequestV1.Solution
ExitV1toalloy-eipsunder a neweip7002moduleWithdrawalRequestalloy_eips::eip7002::WithdrawalRequestasWithdrawalRequestV1PR Checklist