[Timeline] margin configuration option is "broken"

[mvdam]

When upgrading from v4.16.1 to v4.17.0 / v4.18.0 the margin configuration option seems to be "broken". Timeline items that were nicely aligned after each other are now pushed to a new row. See screenshots below;

At v4.16.1 it works fine!

When upgrading to v4.17.0 / v4.18.0 the layout is somewhat broken.

We use the following configuration for "margin".

margin: { axis: 5, item : { vertical: 0, horizontal: 0 } }

Although the margin options still work, you cannot use a value of 0 to prevent items from being pushed to a new row.

[yotamberk]

Set the margin.vertical to -0.5

[yotamberk]

*margin.item.horizontal

[mvdam]

Thank you, your solution works. Is it intended behaviour to use a negative value? Seems more like a hack to me?

[yotamberk]

It is kind of a hack. There is a bug that i couldnt solve elegantly so in the meantime this solves it

[mojoaxel]

It is kind of a hack. There is a bug that i couldnt solve elegantly so in the meantime this solves it

@yotamberk Can you please refer to the issue number of that bug.

[mojoaxel]

@mvdam By the way: You timeline looks realy nicely styled. Is there any chance that you could provide a public example with this style? A would realy like to add something like this to our showcases or our examples.

[yotamberk]

duplicate of #2318
@mojoaxel I remember referring to the PR that introduced this bug. I'll look for it again. I didn't have an elegant way of solving it so I left it as is at the time...

[yotamberk]

found it: #2107

[mojoaxel]

@mvdam See #2318 (comment)
closing as duplicate of #2318

[mvdam]

@mojoaxel Unfortunately I can't give you a live example of our timeline. However if you wish I can create lookalike for the examples page?

[mojoaxel]

Unfortunately I can't give you a live example of our timeline. However if you wish I can create lookalike for the examples page?

@mvdam That would be amazing! At the moment almost all Timelines look the same. If you can com up with a nice styled example I'm more than happy to add it to our examples or showcases.