This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Multiple base edges in clustered edge #3268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for almende#3245. This fix adjusts the clustering edges so that theyi can refer to multiple edges instead of just one. This API method is now insufficient, since multiple base edges can be returned. - Added replacing method `clustering.getBaseEdges()` - Adjusted example `changingClusteredEdgeNodes` for the new method. This is the *only* place where `getBaseEdge()` was used - Adjusted documentation for new method and deprecation old method. Method `getbaseEdge()` should now be considered `deprecated`, and in due time should be removed.
|
@wimrijnders It seems to have conflicts that need to be resolved. |
That's perfectly reasonable; I'll do that. |
|
Conflict fixed |
yotamberk
approved these changes
Jul 21, 2017
|
How to use this feature work for this? In other words, this interact like clustered nodes? |
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* First interim commit * Fixes during testing * Allow multiple edges to be hidden by a clustered edge. Fix for almende#3245. This fix adjusts the clustering edges so that theyi can refer to multiple edges instead of just one. This API method is now insufficient, since multiple base edges can be returned. - Added replacing method `clustering.getBaseEdges()` - Adjusted example `changingClusteredEdgeNodes` for the new method. This is the *only* place where `getBaseEdge()` was used - Adjusted documentation for new method and deprecation old method. Method `getbaseEdge()` should now be considered `deprecated`, and in due time should be removed. * Edits of method name in example * Edits of method name in example * adjusted deprecation method getBaseEdge() in docs * Adjusted deprecation method for getBaseEdge() in docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adjusts the clustering edges so that they can refer to multiple edges instead of just one.
Fix for #3245.
Multiple base edges can be assigned to single clustering edge
Basically, the original single value field
clusteringEdgeReplacingIdhas been replaced by the array-fieldclusteringEdgeReplacingIds, and all associated operations on it have been adjusted.Deprecated method
clustering.getBaseEdge()This API method is now insufficient, since multiple base edges can be returned.
clustering.getBaseEdges()changingClusteredEdgeNodesfor the new method. This is the only place wheregetBaseEdge()was usedMethod
getbaseEdge()should now be considereddeprecated, and in due time should be removed.