Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IEX plugin improvements #170

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

itsankoff
Copy link
Contributor

The PR includes 2 small changes:

  1. Put IEX plugin configuration in actual use
  2. Implement simple filtering of IEX supported symbols to reduce the amount of gathered data. The current implementation show an example with symbols within SPY

@umitanuki
Copy link
Contributor

Thanks for the interesting patch. I think there are use cases for this. But I don't think hard-coded list of symbol is suitable as a general purpose. Why don't you make it fully configurable to specify which symbols to filter?

@itsankoff
Copy link
Contributor Author

Sure, I will push the update soon

@itsankoff
Copy link
Contributor Author

Actually, now I am thinking that you can kind of filtering the symbols if you specify them in the configuration of the iex plugin. But if you want to gather a specific set of symbols the configuration file can grow and become hard to manage.How about implementing filters for NASDAQ sectors:
Aerospace, Auto-Tires-Trucks, Basic Materials, Business Services, Conglomerates, Computers and Technology, Consumer Discretionary, Consumer Staples, Construction, Finance, Industrial Products, Medical, Oils-Energy, Retail-Wholesale, Transportation, Utilities?

@umitanuki
Copy link
Contributor

I agree it's better to specify high-level query term to make it dynamic set of symbols.

@@ -0,0 +1,522 @@
package filter

// SPY is a function which indicates if the given symbols is within S&P500

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// SPY is a function which indicates if the given symbols is within S&P500
// SPY is a function which indicates if the given symbols are within S&P500

return false
}

// SPYSymbols is array symbols which are within S&P500

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// SPYSymbols is array symbols which are within S&P500
// SPYSymbols is an array of symbols which are within S&P500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants