Fix server-side import without breaking window.React

alphagov · Jan 16, 2024 · 1746717 · 1746717
1 parent a15e29e
commit 1746717
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/dist/lib/accessible-autocomplete.preact.min.js b/dist/lib/accessible-autocomplete.preact.min.js
diff --git a/dist/lib/accessible-autocomplete.preact.min.js.map b/dist/lib/accessible-autocomplete.preact.min.js.map
diff --git a/dist/lib/accessible-autocomplete.react.min.js b/dist/lib/accessible-autocomplete.react.min.js
diff --git a/dist/lib/accessible-autocomplete.react.min.js.map b/dist/lib/accessible-autocomplete.react.min.js.map
diff --git a/webpack.config.mjs b/webpack.config.mjs
@@ -167,7 +167,7 @@ const bundlePreact = {
 
     // Support `window.preact` when not bundled
     // e.g. with all dependencies included via unpkg.com
-    globalObject: 'window'
+    globalObject: 'this'
   },
 
   plugins: plugins
@@ -197,15 +197,20 @@ const bundleReact = {
   },
 
   externals: {
-    preact: 'React'
+    preact: {
+      amd: 'react',
+      commonjs: 'react',
+      commonjs2: 'react',
+      root: 'React'
+    }
   },
 
   output: {
     ...config.output,
 
     // Support extending `window.React` when not bundled
     // e.g. with all dependencies included via unpkg.com
-    globalObject: 'window'
+    globalObject: 'this'
   },
 
   plugins: plugins