-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update options for styling component inputs #649
Conversation
2329f73
to
375bd0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🙌
Just the .only()
to remove, the docs changes aren't blockers
Co-authored-by: Colin Rotherham <work@colinr.com>
418c651
to
b972a2d
Compare
Co-authored-by: Colin Rotherham <work@colinr.com>
b972a2d
to
d1967d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Would be ace to see tests for:
- Class only on input and NOT on the hint
- Class only on hint and NOT on the input
Just to make sure hintClasses: ''
etc are working
Yeah, I think it'd be good to look at how to make it easy to have that kind of tests without cluttering the examples:
|
When using the
autoselect
option, the component renders a hint when the value typed by the user matches the start of a suggestion. The styles of this hint need to match some of the styles of the input the user types in so the texts overlap properly. This PR adds a newhintClasses
to complementinputClasses
.It uses the value of
inputClasses
when leftnull
, but can take its own value if necessary to allow either: