Include layout header component styles for /transition #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have made some adjustments to use the layout header component in static where the account navigation should be present. This would be on the transition page as well as Brexit checker pages. This is fine, however some of the layout styles are overriding the layout header component styles in static, resulting in extra padding around the layout header content. Importing these styles into collections seems to fix this issue.
andysellick
approved these changes
Feb 8, 2021
andysellick
reviewed
Feb 9, 2021
There was a problem hiding this comment.
@danacotoran I've suddenly had a thought - the layout header component isn't used in this application, is it? Shouldn't the styles for it go into static instead?
|
@andysellick it's a weird one because the styles are already in static here. But the layout styles take precedence which is why there is extra padding on the right/left. |
|
@andysellick I've opened alphagov/govuk_publishing_components#1924 with a fix for this problem as well as a few other changes. Therefore, will be closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have made some adjustments to use the layout header component in
staticwhere the account navigation should be present. This would be on thetransitionpage as well as Brexit checker pages.For more context: PR to replace hard coded account nav with layout header
This is fine, however some of the layout styles are overriding the layout header component styles in static, resulting in extra left/right padding around the layout header content like so:
Importing the
layout_headerstyles intocollectionsseems to fix the issue:https://trello.com/c/9Kjy1hjb/575-use-header-component-in-static