From d346fe0d1073ee388b2196313cb3eeb2d51bcb19 Mon Sep 17 00:00:00 2001 From: Charlotte Downs <56260216+CharlotteDowns@users.noreply.github.com> Date: Mon, 15 Jul 2024 09:47:56 +0100 Subject: [PATCH 1/4] Add guidance for accessibility of details component Add more reference to the accessibility issues for Dragon users. --- src/components/details/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/details/index.md b/src/components/details/index.md index 11ebe93761..3a7b66c84d 100644 --- a/src/components/details/index.md +++ b/src/components/details/index.md @@ -19,7 +19,7 @@ Use the details component to make a page easier to scan when it contains informa ## When not to use this component -Do not use the details component to hide information that the majority of your users will need. +Do not use the details component to hide information that the majority of your users will need. Read our [research on this component to consider how this affects some users of assistive technologies](/#research-on-this-component) ## Decide between using details, accordions and tabs @@ -45,4 +45,4 @@ Make the link text short and descriptive so users can quickly work out if they n There is [evidence that some users avoid clicking the link to show more details](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-629122091), as they think it will take them away from the page. -There are [concerns that some users of voice assist software will not be able to interact with the component](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-628082040). Some software might require the user to specifically refer to the link to show more details as a button in order to interact with it. +It is known that [some users of voice assist software will not be able to interact with the component](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-628082040). Some software might require the user to specifically refer to the link to show more details as a button in order to interact with it. From 1b4fe833121303ff42b0e3336916b1549ea0bc82 Mon Sep 17 00:00:00 2001 From: Charlotte Downs <56260216+CharlotteDowns@users.noreply.github.com> Date: Mon, 15 Jul 2024 10:11:54 +0100 Subject: [PATCH 2/4] Fix broken links --- src/components/details/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/details/index.md b/src/components/details/index.md index 3a7b66c84d..495866a9a8 100644 --- a/src/components/details/index.md +++ b/src/components/details/index.md @@ -19,7 +19,7 @@ Use the details component to make a page easier to scan when it contains informa ## When not to use this component -Do not use the details component to hide information that the majority of your users will need. Read our [research on this component to consider how this affects some users of assistive technologies](/#research-on-this-component) +Do not use the details component to hide information that the majority of your users will need. Read our [research on this component to consider how this affects some users of assistive technologies](/components/details/#research-on-this-component) ## Decide between using details, accordions and tabs From b4adcf8b255243ec0cc155e6e52af9cb3e0abea6 Mon Sep 17 00:00:00 2001 From: Charlotte Downs <56260216+CharlotteDowns@users.noreply.github.com> Date: Fri, 23 Aug 2024 13:47:49 +0100 Subject: [PATCH 3/4] Apply suggestions from code review Co-authored-by: Owen Jones <64783893+owenatgov@users.noreply.github.com> Co-authored-by: Ed Horsford --- src/components/details/index.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/details/index.md b/src/components/details/index.md index 495866a9a8..61cb38df83 100644 --- a/src/components/details/index.md +++ b/src/components/details/index.md @@ -19,7 +19,7 @@ Use the details component to make a page easier to scan when it contains informa ## When not to use this component -Do not use the details component to hide information that the majority of your users will need. Read our [research on this component to consider how this affects some users of assistive technologies](/components/details/#research-on-this-component) +Do not use the details component to hide information that the majority of your users will need. [Read our research on this component]((/components/details/#research-on-this-component)) to consider how this affects some users of assistive technologies. ## Decide between using details, accordions and tabs @@ -45,4 +45,4 @@ Make the link text short and descriptive so users can quickly work out if they n There is [evidence that some users avoid clicking the link to show more details](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-629122091), as they think it will take them away from the page. -It is known that [some users of voice assist software will not be able to interact with the component](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-628082040). Some software might require the user to specifically refer to the link to show more details as a button in order to interact with it. +[Some users of voice assist software will not be able to interact with the component](https://github.com/alphagov/govuk-design-system-backlog/issues/44#issuecomment-628082040). Some software might require the user to specifically refer to the link to show more details as a button in order to interact with it. From b42f182b1d81b1a69cf007cd47fc380b2ce48ef1 Mon Sep 17 00:00:00 2001 From: Charlotte Downs <56260216+CharlotteDowns@users.noreply.github.com> Date: Wed, 28 Aug 2024 13:40:11 +0100 Subject: [PATCH 4/4] remove additional parentheses --- src/components/details/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/details/index.md b/src/components/details/index.md index 61cb38df83..8598f8571c 100644 --- a/src/components/details/index.md +++ b/src/components/details/index.md @@ -19,7 +19,7 @@ Use the details component to make a page easier to scan when it contains informa ## When not to use this component -Do not use the details component to hide information that the majority of your users will need. [Read our research on this component]((/components/details/#research-on-this-component)) to consider how this affects some users of assistive technologies. +Do not use the details component to hide information that the majority of your users will need. [Read our research on this component](/components/details/#research-on-this-component) to consider how this affects some users of assistive technologies. ## Decide between using details, accordions and tabs