From 9c86cd565dce11168ed80cef8c0ca44ab4b0fe83 Mon Sep 17 00:00:00 2001 From: beeps Date: Mon, 10 Jun 2024 13:00:17 +0100 Subject: [PATCH 1/2] Re-add additional bottom margin to error summary content Reverses a visual change introduced in #4971 where the negative space at the bottom of the Error Summary component was reduced to equalise the container padding on all sides. Although this was originally approved of by a designer on the team, further discussion after the 5.4.0 release concluded that having additional negative space below the Error Summary's content was desirable, as it gave extra space for text descenders to occupy (if present). --- .../src/govuk/components/error-summary/_index.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/govuk-frontend/src/govuk/components/error-summary/_index.scss b/packages/govuk-frontend/src/govuk/components/error-summary/_index.scss index 2453dc66ec..e9ff01866a 100644 --- a/packages/govuk-frontend/src/govuk/components/error-summary/_index.scss +++ b/packages/govuk-frontend/src/govuk/components/error-summary/_index.scss @@ -30,6 +30,10 @@ > * + * { @include govuk-responsive-margin(4, "top"); } + + > :last-child { + @include govuk-responsive-margin(1, "bottom"); + } } // Cross-component class - adjusts styling of list component From 9c6828ebafb8d2998e3ec8fb06b55cbe6408eed9 Mon Sep 17 00:00:00 2001 From: beeps Date: Mon, 10 Jun 2024 13:09:09 +0100 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8ef2e22c21..140083f857 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,7 +9,8 @@ For advice on how to use these release notes see [our guidance on staying up to We've made fixes to GOV.UK Frontend in the following pull requests: - [#5043: Refactor the accordion JavaScript](https://github.com/alphagov/govuk-frontend/pull/5043) -- [##5044: Remove session storage checks from accordion JavaScript](https://github.com/alphagov/govuk-frontend/pull/5044) +- [#5044: Remove session storage checks from accordion JavaScript](https://github.com/alphagov/govuk-frontend/pull/5044) +- [#5060: Reintroduce additional bottom margin to Error Summary content](https://github.com/alphagov/govuk-frontend/pull/5060) ## 5.4.0 (Feature release)