From 782a0910a979406f45cae409955411165cb94571 Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Wed, 4 Dec 2019 11:10:15 +0000 Subject: [PATCH 1/2] Ensure footer links look clickable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We originally removed the underlines from these links to make them consistent with the approach we have for the header component. In order to make sure these links look like links in this component I have reverted this change. Original reasoning for removing underlines: " I believe the intention was to treat the links in the footer in the same way we treat other navigational elements – like the header, or in the case of the Design System the side navigation. Where the ‘thing’ is a ‘list of links’, the thinking is/was that they don’t need the underlining because there’s no wider context in which they need to be distinguished. The exception is any link that does appear within e.g. a paragraph, in which case it does need the underline to distinguish it. It has been questioned a few times on support recently though. The benefit, I believe, is that it allows us to have a clear hover state for those links, which we didn’t previously have " --- src/govuk/components/footer/_footer.scss | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/govuk/components/footer/_footer.scss b/src/govuk/components/footer/_footer.scss index 54f6734e1a..9a9c348289 100644 --- a/src/govuk/components/footer/_footer.scss +++ b/src/govuk/components/footer/_footer.scss @@ -77,19 +77,6 @@ } } - // Internet Explorer 8 does not support `:not()` selectors, so don't conditionally show underlines. - @include govuk-not-ie8 { - .govuk-footer__inline-list .govuk-footer__link, - .govuk-footer__list .govuk-footer__link { - text-decoration: none; - - &:hover:not(:focus), - &:active:not(:focus) { - text-decoration: underline; - } - } - } - .govuk-footer__section-break { margin: 0; // Reset `
` default margins @include govuk-responsive-margin(8, "bottom"); From a552760dd7cdadee29d4ee071725d88d1138f74c Mon Sep 17 00:00:00 2001 From: Nick Colley Date: Mon, 9 Dec 2019 16:08:51 +0000 Subject: [PATCH 2/2] Update CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b6e903ec5b..ca52a455a1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ If you're using Nunjucks, you can now add classes to the character count compone ### Fixes - [Pull request #1676: Fix skip link component focus style with global styles enabled](https://github.com/alphagov/govuk-frontend/pull/1676). +- [Pull request #1672: Ensure footer links look clickable](https://github.com/alphagov/govuk-frontend/pull/1672). - [Pull request #1670: Make width-container margins more targetted to avoid specificity issues](https://github.com/alphagov/govuk-frontend/pull/1670). - [Pull request #1655: Ensure components use public `govuk-media-query` mixin](https://github.com/alphagov/govuk-frontend/pull/1655). - [Pull request #1648: Update checkboxes and radio buttons to include item hint classes on item hint](https://github.com/alphagov/govuk-frontend/pull/1648)