From 7c26db1a06ad320d62aa5bfa06c08c4e42e113f6 Mon Sep 17 00:00:00 2001 From: Oliver Byford Date: Thu, 9 Jan 2020 10:12:55 +0000 Subject: [PATCH 1/2] Don't unneccesarily self-close tags We're currently inconsistent as to whether we self-close void elements or not. The self-closing / has no effect on the start tags of void elements in HTML5.[1] For this reason, we should standardise on omitting them. [1]: https://html.spec.whatwg.org/dev/syntax.html#start-tags --- src/govuk/template.njk | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/govuk/template.njk b/src/govuk/template.njk index f9308a49c1..13a170f25c 100644 --- a/src/govuk/template.njk +++ b/src/govuk/template.njk @@ -6,15 +6,15 @@ - + {% block pageTitle %}GOV.UK - The best place to find government services and information{% endblock %} - {# Hardcoded value of $govuk-black #} + {# Hardcoded value of $govuk-black #} {# Ensure that older IE versions always render with the correct rendering engine #} - + {% block headIcons %} - + {# Hardcoded value of $govuk-black #} From 898f3685402f777e17347d5a5fa462f3eb17851a Mon Sep 17 00:00:00 2001 From: Oliver Byford Date: Thu, 9 Jan 2020 10:20:44 +0000 Subject: [PATCH 2/2] Add to CHANGELOG --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4918e97149..1c5d8b1b69 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,7 @@ If you're using Nunjucks, you can now add classes to the character count compone ### Fixes +- [Pull request #1690: Don't unneccesarily self-close tags](https://github.com/alphagov/govuk-frontend/pull/1690) - [Pull request #1678: Fix tabs component throwing JavaScript errors in Internet Explorer 8](https://github.com/alphagov/govuk-frontend/pull/1678). - [Pull request #1676: Fix skip link component focus style with global styles enabled](https://github.com/alphagov/govuk-frontend/pull/1676). - [Pull request #1672: Ensure footer links look clickable](https://github.com/alphagov/govuk-frontend/pull/1672).