From 8a379f7765161c0802bdfeed00771d2b89d8ee3e Mon Sep 17 00:00:00 2001 From: Vanita Barrett Date: Fri, 16 Apr 2021 15:31:42 +0100 Subject: [PATCH 1/3] Add data-nosnippet to the cookie banner component The data-nosnippet attribute stops the cookie banner text from appearing in any Google Search text snippets. --- src/govuk/components/cookie-banner/template.njk | 2 +- src/govuk/components/cookie-banner/template.test.js | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/govuk/components/cookie-banner/template.njk b/src/govuk/components/cookie-banner/template.njk index 8e016f9168..c539b5b3f0 100644 --- a/src/govuk/components/cookie-banner/template.njk +++ b/src/govuk/components/cookie-banner/template.njk @@ -1,6 +1,6 @@ {% from "../button/macro.njk" import govukButton -%} -
diff --git a/src/govuk/components/cookie-banner/template.test.js b/src/govuk/components/cookie-banner/template.test.js index e9c2276adc..6b7579354d 100644 --- a/src/govuk/components/cookie-banner/template.test.js +++ b/src/govuk/components/cookie-banner/template.test.js @@ -248,6 +248,13 @@ describe('Cookie Banner', () => { const $actions = $('.govuk-cookie-banner__message[hidden]') expect($actions.length).toEqual(2) }) + + it('has a data-nosnippet attribute to hide it from search result snippets', () => { + const $ = render('cookie-banner', examples['client-side implementation']) + + const $parentContainer = $('.govuk-cookie-banner') + expect($parentContainer.attr('data-nosnippet')).toEqual('') + }) }) describe('full cookie banner hidden', () => { From d3226ce5064d1c72e146b6d710e1a3a9babfda46 Mon Sep 17 00:00:00 2001 From: Vanita Barrett Date: Fri, 16 Apr 2021 15:33:19 +0100 Subject: [PATCH 2/3] Add missing cookie banner component README --- src/govuk/components/cookie-banner/README.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 src/govuk/components/cookie-banner/README.md diff --git a/src/govuk/components/cookie-banner/README.md b/src/govuk/components/cookie-banner/README.md new file mode 100644 index 0000000000..1c9198084f --- /dev/null +++ b/src/govuk/components/cookie-banner/README.md @@ -0,0 +1,15 @@ +# Cookie banner + +## Installation + +See the [main README quick start guide](https://github.com/alphagov/govuk-frontend#quick-start) for how to install this component. + +## Guidance and Examples + +Find out when to use the cookie banner component in your service in the [GOV.UK Design System](https://design-system.service.gov.uk/components/cookie-banner). + +## Component options + +Use options to customise the appearance, content and behaviour of a component when using a macro, for example, changing the text. + +See [options table](https://design-system.service.gov.uk/components/cookie-banner/#options-default-cookie-banner-example) for details. From c4ef8b5183fe1615e68b97daa867bfd73888a645 Mon Sep 17 00:00:00 2001 From: Vanita Barrett Date: Fri, 16 Apr 2021 15:34:42 +0100 Subject: [PATCH 3/3] Add to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2b7ed2fad9..bfe0355953 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -18,6 +18,7 @@ This was added in [pull request #2164: Enable cookie banner to set link styled a - [#2157: Use pointer cursor for 'Menu' button in header](https://github.com/alphagov/govuk-frontend/pull/2157) – thanks to [@MalcolmVonMoJ](https://github.com/MalcolmVonMoJ) for contributing this. - [#2171: Fix padding on GOV.UK logo affecting hover and focus states](https://github.com/alphagov/govuk-frontend/pull/2171) - [#2186: Fix display of warning text in Edge when Windows High Contrast Mode is enabled](https://github.com/alphagov/govuk-frontend/pull/2186) +- [#2192: Add data-nosnippet to prevent cookie banner text appearing in Google Search snippets](https://github.com/alphagov/govuk-frontend/pull/2192) ## 3.11.0 (Feature release)