From da1724509cff4d2faaf82d683ae68e89f9f87b10 Mon Sep 17 00:00:00 2001 From: Jani Kraner Date: Fri, 4 May 2018 13:57:57 +0100 Subject: [PATCH 1/2] Section border styles fix when used with Elements `
` styling in Elements has background and height set, whereas in Frontend we're using border bottom. To fix, `height:0` was added in a compatibility conditional include. --- src/globals/core/_section-break.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/globals/core/_section-break.scss b/src/globals/core/_section-break.scss index 8bed959250..d5b910df1a 100644 --- a/src/globals/core/_section-break.scss +++ b/src/globals/core/_section-break.scss @@ -5,6 +5,12 @@ %govuk-section-break { margin: 0; border: 0; + + // fix double-width section break and forced visible section break + // when combined with styles from alphagov/elements + @include govuk-compatibility(govuk_elements) { + height: 0; + } } .govuk-section-break { From 7f7e8920b92dd31fd0665ba48861ce25fdbb40bf Mon Sep 17 00:00:00 2001 From: Jani Kraner Date: Fri, 4 May 2018 14:00:14 +0100 Subject: [PATCH 2/2] Document in CHANGELOG --- CHANGELOG.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 51e72d67d5..2fc09f2fd5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -33,6 +33,9 @@ Fixes: - Reinstate focus outline for radios and checkboxes on IE8 (PR [#670](https://github.com/alphagov/govuk-frontend/pull/670)) +- Fix section break styles when used with GOV.UK Elements + ([PR #682](https://github.com/alphagov/govuk-frontend/pull/682)) + New features: - We're now using ES6 Modules and [rollup](https://rollupjs.org/guide/en) to distribute our JavaScript. (PR [#652](https://github.com/alphagov/govuk-frontend/pull/652))