Merge pull request #1962 from alphagov/fix-bespoke-details-tracking

Fix tracking in details.js
alphagov · Mar 8, 2021 · ab6e01d · ab6e01d
2 parents c626d1e + 545a9e0
commit ab6e01d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@
   useful summary for people upgrading their application, not a replication
   of the commit log.
 
+## Unreleased
+
+* Fix tracking in `details.js` ([PR #1962](https://github.com/alphagov/govuk_publishing_components/pull/1962))
+
 ## 24.4.0
 
 * Add border option to breadcrumb ([PR #1952](https://github.com/alphagov/govuk_publishing_components/pull/1952)) MINOR

diff --git a/app/assets/javascripts/govuk_publishing_components/components/details.js b/app/assets/javascripts/govuk_publishing_components/components/details.js
@@ -13,7 +13,7 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
 
     // If a custom label has been provided, we can simply call the tracking module
     if (customTrackLabel) {
-      var trackDetails = new window.GOVUK.Modules.TrackClick()
+      var trackDetails = new window.GOVUK.Modules.GemTrackClick()
       trackDetails.start($module)
     } else {
       // If no custom label is set, we use the open/close status as the label

diff --git a/spec/javascripts/components/details-spec.js b/spec/javascripts/components/details-spec.js
@@ -4,20 +4,14 @@
 describe('Details component', function () {
   var FIXTURE
 
-  var callback = jasmine.createSpy()
-  GOVUK.Modules.TrackClick = function () {
-    this.start = function () {
-      callback()
-    }
-  }
-
   function loadDetailsComponent () {
     var details = new GOVUK.Modules.GovukDetails()
     details.start($('.gem-c-details'))
   }
 
   beforeEach(function () {
     spyOn(GOVUK.analytics, 'trackEvent')
+    spyOn(GOVUK.Modules, 'GemTrackClick').and.callFake(function () { this.start = function () {} })
 
     FIXTURE =
       '<details class="gem-c-details govuk-details govuk-!-margin-bottom-3" data-track-category="track-category" data-track-action="track-action" data-track-label="track-label" data-module="govuk-details">' +
@@ -41,7 +35,7 @@ describe('Details component', function () {
     $('.govuk-details__summary').click()
 
     expect(GOVUK.analytics.trackEvent.calls.count()).toEqual(0)
-    expect(callback).toHaveBeenCalled()
+    expect(GOVUK.Modules.GemTrackClick.calls.count()).toEqual(1)
   })
 
   it('does not fire an event if track category and track action are not present', function () {