Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies banner previews are broken with javascript disabled #1932

Closed
maxgds opened this issue Feb 16, 2021 · 1 comment · Fixed by #1935
Closed

Cookies banner previews are broken with javascript disabled #1932

maxgds opened this issue Feb 16, 2021 · 1 comment · Fixed by #1935
Labels
bug

Comments

@maxgds
Copy link
Contributor

maxgds commented Feb 16, 2021

The Cookies Banner component is written so that if the user doesn't have js switched on/working they should see the component persist with links through to the settings page. This works in production but fails on the documentation page for reasons currently unknown - instead of seeing the banner the previews show up as blank alongside the example implementation code.
@maxgds maxgds added the bug label Feb 16, 2021
@alex-ju
Copy link
Contributor

alex-ju commented Feb 16, 2021

I think we only need to remove these lines for it to work.

@alex-ju alex-ju mentioned this issue Feb 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cookie banner preview in the component guide alphagov/govuk_publishing_components
2 participants
@alex-ju @maxgds