diff --git a/sw/device/silicon_creator/lib/base/sec_mmio_unittest.cc b/sw/device/silicon_creator/lib/base/sec_mmio_unittest.cc index d6f2a43697cd63..f450c7cb5bddea 100644 --- a/sw/device/silicon_creator/lib/base/sec_mmio_unittest.cc +++ b/sw/device/silicon_creator/lib/base/sec_mmio_unittest.cc @@ -173,54 +173,53 @@ TEST_F(SecMmioTest, CheckCount) { EXPECT_EQ(ctx_->check_count, 2); } -// Negative test cases trigger assertions, which are caugth by `ASSERT_DEATH` -// calls. All test cases use lambda functions to wrap expectations and work -// around issue google/googletest#1004. +// Negative test cases trigger assertions, which are caugth by `EXPECT_DEATH` +// calls. class SecMmioDeathTest : public SecMmioTest {}; TEST_F(SecMmioDeathTest, Read32OrDieSimulatedFault) { - ASSERT_DEATH( - [] { + EXPECT_DEATH( + { EXPECT_ABS_READ32(0, 0x12345678); EXPECT_ABS_READ32(0, 0); sec_mmio_read32(0); - }(), + }, ""); } TEST_F(SecMmioDeathTest, Write32SimulatedFault) { - ASSERT_DEATH( - [] { + EXPECT_DEATH( + { EXPECT_ABS_WRITE32(0, 0x12345678); EXPECT_ABS_READ32(0, 0); sec_mmio_write32(0, 0x12345678); - }(), + }, ""); } TEST_F(SecMmioDeathTest, CheckValuesSimulatedFault) { - ASSERT_DEATH( - [] { + EXPECT_DEATH( + { EXPECT_ABS_WRITE32(0, 0x12345678); EXPECT_ABS_READ32(0, 0x12345678); sec_mmio_write32(0, 0x12345678); EXPECT_ABS_READ32(0, 0); sec_mmio_check_values(/*rnd_offset=*/0); - }(), + }, ""); } TEST_F(SecMmioDeathTest, CheckCountWriteMismatch) { // The developer forgot to increment the write counter, or an attacker // glitched the sec write operation. - ASSERT_DEATH( - [] { + EXPECT_DEATH( + { EXPECT_ABS_WRITE32(0, 0x12345678); EXPECT_ABS_READ32(0, 0x12345678); sec_mmio_write32(0, 0x12345678); sec_mmio_check_counters(/*expected_check_count=*/0); - }(), + }, ""); } diff --git a/sw/device/silicon_creator/lib/drivers/lifecycle_unittest.cc b/sw/device/silicon_creator/lib/drivers/lifecycle_unittest.cc index 488df70b4e0c14..af95ccf1658e50 100644 --- a/sw/device/silicon_creator/lib/drivers/lifecycle_unittest.cc +++ b/sw/device/silicon_creator/lib/drivers/lifecycle_unittest.cc @@ -124,7 +124,7 @@ class LifecycleDeathTest : public LifecycleTest, public testing::WithParamInterface {}; TEST_P(LifecycleDeathTest, InvalidState) { - ASSERT_DEATH( + EXPECT_DEATH( { EXPECT_SEC_READ32(base_ + LC_CTRL_LC_STATE_REG_OFFSET, GetParam()); lifecycle_state_get(); diff --git a/sw/device/silicon_creator/lib/sigverify_unittest.cc b/sw/device/silicon_creator/lib/sigverify_unittest.cc index 461673a57a9d5c..cda6028013f6a1 100644 --- a/sw/device/silicon_creator/lib/sigverify_unittest.cc +++ b/sw/device/silicon_creator/lib/sigverify_unittest.cc @@ -170,7 +170,7 @@ INSTANTIATE_TEST_SUITE_P(NonTestOperationalStates, SigverifyInNonTestStates, class SigverifyInNonTestStatesDeathTest : public SigverifyInLcState {}; TEST_P(SigverifyInNonTestStatesDeathTest, BadOtpValue) { - ASSERT_DEATH( + EXPECT_DEATH( { EXPECT_CALL( otp_, diff --git a/sw/device/silicon_creator/mask_rom/sigverify_keys_unittest.cc b/sw/device/silicon_creator/mask_rom/sigverify_keys_unittest.cc index a0ba367c292549..8a581be44e909b 100644 --- a/sw/device/silicon_creator/mask_rom/sigverify_keys_unittest.cc +++ b/sw/device/silicon_creator/mask_rom/sigverify_keys_unittest.cc @@ -180,7 +180,7 @@ TEST_P(BadKeyIdTypeDeathTest, BadKeyType) { }; const sigverify_rsa_key_t *key; - ASSERT_DEATH( + EXPECT_DEATH( { ExpectKeysPtrGet(keys); sigverify_rsa_key_get(key_id, GetParam(), &key); @@ -206,7 +206,7 @@ TEST_P(NonOperationalStateDeathTest, BadKey) { std::tie(key_index, lc_state) = GetParam(); const sigverify_rsa_key_t *key; - ASSERT_DEATH( + EXPECT_DEATH( { ExpectKeysPtrGet(kMockKeys); sigverify_rsa_key_get(