From 3f920283d276ade9110ab0294d4febd718e8fe7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C4=83t=C4=83lin=20Mari=C8=99?= <contact@catalinmaris.com>
Date: Sun, 1 Dec 2024 09:36:05 -0800
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20Make=20`resize-video`=20use=20th?=
 =?UTF-8?q?e=20same=20default=20for=20`crf`=20as=20`ffmpeg`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

From https://trac.ffmpeg.org/wiki/Encode/H.264#a1.ChooseaCRFvalue

 " The range of the CRF scale is 0–51, where 0 is lossless
   (for 8 bit only, for 10 bit use -qp 0), 23 is the default... "
---
 src/shell/bash_functions | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/shell/bash_functions b/src/shell/bash_functions
index 477691f1..e97b453d 100755
--- a/src/shell/bash_functions
+++ b/src/shell/bash_functions
@@ -292,7 +292,7 @@ resize-image() {
 # $1: Path to the original video file.
 # $2: Resolution (default is '1920:1080').
 # $3: Start time (default is '00:00:00').
-# $4: Constant Rate Factor (default is '25').
+# $4: Constant Rate Factor (default is '23').
 #
 # Usage examples:
 #
@@ -322,7 +322,7 @@ resize-video() {
     declare filePath="$(dirname "${1%/}")"
     declare scale="${2:-1920:1080}"
     declare startTime=${3:-00:00:00}
-    declare crf=${4:-25}
+    declare crf=${4:-23}
 
     declare outputFileName="$filePath/_${fileName%.*}.mp4"