Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New index columns are not deterministic #24

Closed
thehomebrewnerd opened this issue Apr 17, 2020 · 1 comment
Closed

New index columns are not deterministic #24

thehomebrewnerd opened this issue Apr 17, 2020 · 1 comment

Comments

@thehomebrewnerd
Copy link
Contributor

thehomebrewnerd commented Apr 17, 2020 •
edited
Loading

New index column names are not deterministic as they are created by joining together items in an unsorted list in make_indexes() in normalize.py. This should be updated so that new index names are consistent from run to run. This can be accomplished by sorting the list prior to joining into a new column name.

After making this update, the tests implemented in PR #12 should also be reviewed and updated if needed.
@thehomebrewnerd thehomebrewnerd mentioned this issue Apr 17, 2020
Open
@thehomebrewnerd
Copy link
Contributor Author

Closed by #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehomebrewnerd