From 18ecd2177be07835954ce8326e914ff9943932e4 Mon Sep 17 00:00:00 2001
From: amansinghbais <singh11amanbais@gmail.com>
Date: Tue, 12 Dec 2023 16:55:14 +0530
Subject: [PATCH] Improved: prop name, fieldList for fetching jobHistory, and
 component name (#641)

---
 src/components/JobHistoryModal.vue | 2 +-
 src/views/FailedJobReasonModal.vue | 6 +++---
 src/views/Pipeline.vue             | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/components/JobHistoryModal.vue b/src/components/JobHistoryModal.vue
index bc4e032c..51befe55 100644
--- a/src/components/JobHistoryModal.vue
+++ b/src/components/JobHistoryModal.vue
@@ -99,7 +99,7 @@ export default defineComponent({
             "statusId_op": "in",
             "systemJobEnumId": this.currentJob?.systemJobEnumId
           },
-          "fieldList": [ "jobResult", "runTime", "statusId" ],
+          "fieldList": [ "runTime", "statusId" ],
           "noConditionFind": "Y",
           "viewSize": process.env.VUE_APP_VIEW_SIZE,
           "orderBy": "runTime DESC"
diff --git a/src/views/FailedJobReasonModal.vue b/src/views/FailedJobReasonModal.vue
index 147c010d..50cdded5 100644
--- a/src/views/FailedJobReasonModal.vue
+++ b/src/views/FailedJobReasonModal.vue
@@ -11,7 +11,7 @@
   </ion-header>
   <ion-content>
     <ion-item lines="none">
-      <p>{{ currentJob.jobResult }}</p>
+      <p>{{ job.jobResult }}</p>
     </ion-item>
   </ion-content>
 </template>
@@ -32,7 +32,7 @@ import { defineComponent } from 'vue';
 import { closeOutline } from 'ionicons/icons';
 
 export default defineComponent({
-  name: "SelectJobsModal",
+  name: "FailedJobReasonModal",
   components: {
     IonButton,
     IonButtons,
@@ -43,7 +43,7 @@ export default defineComponent({
     IonTitle,
     IonToolbar
   },
-  props: ["currentJob"],
+  props: ["job"],
   methods: { 
     closeModal() {
       modalController.dismiss({ dismissed: true });
diff --git a/src/views/Pipeline.vue b/src/views/Pipeline.vue
index 4d4e8766..ca8c0f81 100644
--- a/src/views/Pipeline.vue
+++ b/src/views/Pipeline.vue
@@ -394,7 +394,7 @@ export default defineComponent({
     async openFailedJobReason(job: any) {
       const jobHistoryModal = await modalController.create({
         component: FailedJobReasonModal,
-        componentProps: { currentJob: job }
+        componentProps: { job }
       });
 
       return jobHistoryModal.present();