diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b80094410..8284910c4b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -137,15 +137,6 @@ jobs: mkdir -p /usr/share/librealsense2/presets sudo apt-get install librealsense2-dev - # Workaround for https://github.com/ami-iit/bipedal-locomotion-framework/issues/636 - - name: Cmake 3.25.3 [Ubuntu] - if: startsWith(matrix.os, 'ubuntu') - run: | - curl -sL https://github.com/Kitware/CMake/releases/download/v3.25.3/cmake-3.25.3-linux-x86_64.sh -o cmakeinstall.sh \ - && chmod +x cmakeinstall.sh \ - && sudo ./cmakeinstall.sh --prefix=/usr/local --exclude-subdir \ - && rm cmakeinstall.sh - - name: Cache Source-based Dependencies id: cache-source-deps uses: actions/cache@v3 diff --git a/CHANGELOG.md b/CHANGELOG.md index 0ce6aec3f6..5d3ba234f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -28,6 +28,7 @@ All notable changes to this project are documented in this file. - Return an error if an invalid `KinDynComputations` object is passed to `QPInverseKinematics::build()` (https://github.com/ami-iit/bipedal-locomotion-framework/pull/622) - Fix `QPTSIF` documentation (https://github.com/ami-iit/bipedal-locomotion-framework/pull/634) - Fix error messages in `QPTSID` class (https://github.com/ami-iit/bipedal-locomotion-framework/pull/639) +- Fix compilation failure when using CMake 3.26.1 and pybind11 2.4.3 (https://github.com/ami-iit/bipedal-locomotion-framework/pull/643) ## [0.12.0] - 2023-03-07 ### Added diff --git a/cmake/BipedalLocomotionFrameworkDependencies.cmake b/cmake/BipedalLocomotionFrameworkDependencies.cmake index a00fa4a60d..3ba1a4e7fa 100644 --- a/cmake/BipedalLocomotionFrameworkDependencies.cmake +++ b/cmake/BipedalLocomotionFrameworkDependencies.cmake @@ -5,6 +5,15 @@ include(BipedalLocomotionFrameworkFindDependencies) include(BipedalLocomotionDependencyClassifier) +# Workaround for issue that occurs with CMake 3.26.1 and pybind11 2.4.3 +# see https://github.com/ami-iit/bipedal-locomotion-framework/issues/636 +# This is done here as it needs to be done before any call (even transitive) +# to find_package(pybind11) +# It can be removed once pybind11 2.4.3 is not supported anymore +if(NOT DEFINED CMAKE_CXX_STANDARD) + set(CMAKE_CXX_STANDARD 17) +endif() + ################################################################################ ########################## Mandatory dependencies ##############################