Scalable usdc-spot univ3 strategy #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scalable usdc-spot univ3 strategy
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
aalavandhan
force-pushed
the
spot-charm
branch
from
f96c1cb to
fd2a105
Compare
brandoniles
reviewed
Oct 28, 2024
aalavandhan
commented
Oct 30, 2024
| // IMPORTANT: The deviation percentage, to ticks conversion isn't precise. | ||
| // In the worst case, there might be liquidity up to 2% outside the active zone definition. | ||
| VAULT.setBaseThreshold(deviationToTicks(concBandDeviationWidth)); | ||
| VAULT.setLimitThreshold(deviationToTicks(limitBandDeviationWidth)); |
Member
Author
There was a problem hiding this comment.
We can consider removing the limit ranges completely when it's buying above fmv and selling below. It does slightly reduce the opportunity of getting back to 50/50 in the long run, however it also eliminates IL.
But considering the active zone is quite tight to begin with maybe it doesn't matter.
Member
There was a problem hiding this comment.
If we can, we should have the logic make sense independent of configuration. At this stage, it's best if we don't make any assumptions about how tight the active zone is
Member
Author
There was a problem hiding this comment.
Okay, rethinking this framing re IL. I think the original implementation makes the most sense. We keep concentrated/limit liquidity when in the active zone and revert to bounded infinite band when outside.
aalavandhan
commented
Nov 4, 2024
aalavandhan
force-pushed
the
spot-charm
branch
from
6a626c2 to
d91e547
Compare
aalavandhan
force-pushed
the
charm-pricer
branch
2 times, most recently
from
e69fd34 to
0e371bc
Compare
aalavandhan
force-pushed
the
spot-charm
branch
from
d91e547 to
30d1298
Compare
aalavandhan
force-pushed
the
charm-pricer
branch
from
0e371bc to
5f9abfc
Compare
aalavandhan
force-pushed
the
spot-charm
branch
from
30d1298 to
46ab8dd
Compare
aalavandhan
force-pushed
the
charm-pricer
branch
from
5f9abfc to
56a002d
Compare
aalavandhan
force-pushed
the
spot-charm
branch
from
2bbb039 to
11487f4
Compare
aalavandhan
force-pushed
the
charm-pricer
branch
from
56a002d to
5689d1e
Compare
aalavandhan
force-pushed
the
spot-charm
branch
from
11487f4 to
fa33d8a
Compare
brandoniles
reviewed
Nov 8, 2024
| function rebalance() public { | ||
| (uint256 deviation, bool deviationValid) = oracle.spotPriceDeviation(); | ||
| bool withinActiveZone = (deviationValid && activeZone(deviation)); | ||
| bool withinActiveZoneBefore = activeZone(prevDeviation); |
Member
There was a problem hiding this comment.
Consider caching the boolean withinActiveZoneBefore, rather than recomputing it from the cached prevDeviation each time.
Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> review fix caching bool instead of prev deviation
aalavandhan
force-pushed
the
spot-charm
branch
from
bf2433a to
c9f8780
Compare
aalavandhan
added a commit
that referenced
this pull request
May 8, 2025
* Bump coverallsapp/github-action from 2.3.0 to 2.3.3 (#228) Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.0 to 2.3.3. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.3.0...v2.3.3) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * updated cdr pricer (#229) * Deployed v4.1.0 implementations * Bump coverallsapp/github-action from 2.3.3 to 2.3.4 (#230) Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.3 to 2.3.4. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.3.3...v2.3.4) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * updated spot subgraph to keep track of vault swap volume * Vault Refactor & Meta Oracle (#224) * removed pricing strategies in favor of meta oracle * Bill broker refactor, using new meta oracle * Charm vault refactor, using new meta oracle * Updated Interfaces and Errors * updated unit tests * code review changes * Scalable usdc spot strategy (#231) Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> review fix caching bool instead of prev deviation * billy subgraph (#234) * Deployed new oracle contract and managers (#233) * deployed new oracle and managers * updated readme * Staking subgraph (#235) * staking subgraph, refreshing store on rebase * charm wampl vault subgraph * adds timestamp to swap events subgraph (#236) * adds timestamp to swap events subgraph Signed-off-by: nms-7 <nixon.ubud@gmail.com> * linting Signed-off-by: nms-7 <nixon.ubud@gmail.com> * fixed null swap creation with 0 timestamp Signed-off-by: nms-7 <nixon.ubud@gmail.com> --------- Signed-off-by: nms-7 <nixon.ubud@gmail.com> * Bump coverallsapp/github-action from 2.3.4 to 2.3.6 (#238) Bumps [coverallsapp/github-action](https://github.com/coverallsapp/github-action) from 2.3.4 to 2.3.6. - [Release notes](https://github.com/coverallsapp/github-action/releases) - [Commits](coverallsapp/github-action@v2.3.4...v2.3.6) --- updated-dependencies: - dependency-name: coverallsapp/github-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bill broker fee curve change (#237) * using fee factor instead of percentages to support -ve fees * unit tests * code review * convergent fee curve * updated charm fee yield logic (#239) * Fee curve update (#232) * fee curve update * code review fixes * Rollover fee curve update (#240) * rollover fee handles undersubscribed vault * bumped up hardhat * code review comments * DR based flash swap fees * comment updates * updated unit tests to use ethers v6, using custom mocking library * updated tasks and deps * updated perp mint fees to be paid to the vault * removed perp share of fees from flash swaps, all fees go to the vault * added configurable dr soft bounds (curve cutoff point) to flash swap fees * updated unit tests * removed rollover fees from perp * Daily Rebalance * updated unit tests * constant rate enrichment/debasement * mint2, redeem2 * added linked library to limit contract size * unit tests * melding perps immediately after rebalance * Apply suggestions from code review Suggestions Co-authored-by: Brandon Iles <brandon@fragments.org> * Update spot-contracts/contracts/FeePolicy.sol Co-authored-by: Brandon Iles <brandon@fragments.org> * code review fixes * code review fixes v2 * code review fixes v3 * code review v4 * during rebalance, vault pays perps by transferring tranches into perp's reserve * rebalance eql * configurable rebalance freq * code review v5 * Apply suggestions from code review Co-authored-by: Brandon Iles <brandon@fragments.org> * code review fixes * Code review fixes Co-authored-by: Brandon Iles <brandon@fragments.org> * bill broker single sided deposit fix (#253) * Dev Audit Changes (#252) * fee policy restructure * updated perp fee and rebalance handling, audit cleanup * updated vault fee and rebalance handling, audit cleanup * interface and lib updates * updated unit tests * code review fixes #1 * code review fixes #2 * code review fix #3 * Removed subscription ratio for a global vault:perp tvl (or system ratio) (#254) * Using a system ratio target * using system state to calculate fees * using system state for fees and removed subscription liquidity check * interface updates * unit test updates * rename * updated deps --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: nms-7 <nixon.ubud@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nms-7 <57442379+nms-7@users.noreply.github.com> Co-authored-by: Brandon Iles <brandon@fragments.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An new alpha vault strategy for spot-usdc which is scalable and can provide deep concentrated liquidity around SPOT's fmv.