test: add setUserId test

Author: yuhao900914

src/amplitude-client.js

@@ -1435,6 +1435,7 @@ AmplitudeClient.prototype.logEvent = function logEvent(
  * @param {Amplitude~eventCallback} opt_error_callback - (optional) a callback function to run after the event logging
  * fails. The failure can be from the request being malformed or from a network failure
  * Note: the server response code and response body from the event upload are passed to the callback function.
+ * @param {boolean} outOfSession - (optional) if out of the sessioin or not
  * @example amplitudeClient.logEvent('Clicked Homepage Button', {'finished_flow': false, 'clicks': 15});
  */
 AmplitudeClient.prototype.logEventWithTimestamp = function logEvent(
@@ -1443,7 +1444,7 @@ AmplitudeClient.prototype.logEventWithTimestamp = function logEvent(
   timestamp,
   opt_callback,
   opt_error_callback,
-  outOfSession,
+  outOfSession = false,
 ) {
   if (this._shouldDeferCall()) {
     return this._q.push(['logEventWithTimestamp'].concat(Array.prototype.slice.call(arguments, 0)));

test/amplitude-client.js

@@ -2840,6 +2840,18 @@ describe('AmplitudeClient', function () {
     });
   });
 
+  describe('logEvent with outOfSession', function () {
+    this.beforeEach(function () {
+      reset();
+    });
+
+    it('should reset the sessionId', function () {
+      amplitude.init(apiKey);
+      amplitude.logEvent('Event Type', null, null, null, true);
+      assert.equal(amplitude._sessionId, -1);
+    });
+  });
+
   describe('setEventUploadThreshold', function () {
     beforeEach(function () {
       reset();
@@ -4387,4 +4399,53 @@ describe('AmplitudeClient', function () {
       assert.equal(amplitude._unsentEvents.length, 0);
     });
   });
+
+  describe('setUserId', function () {
+    let clock, startTime;
+    beforeEach(function () {
+      reset();
+      startTime = Date.now();
+      clock = sinon.useFakeTimers(startTime);
+      amplitude.init(apiKey);
+    });
+
+    it('should not renew the session id with invalid startNewSession input', function () {
+      var amplitude = new AmplitudeClient();
+      // set up initial session
+      var sessionId = 1000;
+      clock.tick(sessionId);
+      amplitude.init(apiKey);
+      assert.equal(amplitude.getSessionId(), startTime);
+
+      amplitude.setUserId('test user', 'invalid startNewSession');
+      assert.notEqual(amplitude.getSessionId(), new Date().getTime());
+      assert.notEqual(amplitude.options.userId, 'test user');
+    });
+
+    it('should renew the session id with current timestemp', function () {
+      var amplitude = new AmplitudeClient();
+      // set up initial session
+      var sessionId = 1000;
+      clock.tick(sessionId);
+      amplitude.init(apiKey);
+      assert.equal(amplitude.getSessionId(), startTime);
+
+      amplitude.setUserId('test user', true);
+      assert.equal(amplitude.getSessionId(), new Date().getTime());
+      assert.equal(amplitude.options.userId, 'test user');
+    });
+
+    it('should continue the old session', function () {
+      var amplitude = new AmplitudeClient();
+      // set up initial session
+      var sessionId = 1000;
+      clock.tick(sessionId);
+      amplitude.init(apiKey);
+      assert.equal(amplitude.getSessionId(), startTime);
+
+      amplitude.setUserId('test user');
+      assert.equal(amplitude.getSessionId(), startTime);
+      assert.equal(amplitude.options.userId, 'test user');
+    });
+  });
 });