patch: make setLibrary function able to seprate set library name and version

Author: yuhao900914

src/amplitude-client.js

@@ -1908,30 +1908,13 @@ AmplitudeClient.prototype.__VERSION__ = function getVersion() {
  * @param {string} name - Custom library name
  * @param {string} version - Custom library version
  */
-AmplitudeClient.prototype.setLibrary = function setLibrary(name, version) {
+AmplitudeClient.prototype.setLibrary = function setLibrary(
+  name = this.options.libraryName,
+  version = this.options.libraryVersion,
+) {
   this.options.library = { name: name, version: version };
 };
 
-/**
- * Sets the library name.
- * @public
- * @param {string} libraryName - the library name.
- * @example amplitudeClient.setLibraryName('my_library_name');
- */
-AmplitudeClient.prototype.setLibraryName = function setLibraryName(libraryName) {
-  this.options.library.name = libraryName;
-};
-
-/**
- * Sets the library Version.
- * @public
- * @param {string} userId - the library version.
- * @example amplitudeClient.setLibraryVersion('1.0.0');
- */
-AmplitudeClient.prototype.setLibraryVersion = function setLibraryVersion(libraryVersion) {
-  this.options.library.version = libraryVersion;
-};
-
 /**
  * Determines whether or not to push call to this._q or invoke it
  * @private
@@ -2063,7 +2046,7 @@ AmplitudeClient.prototype.setUseDynamicConfig = function setUseDynamicConfig(use
 };
 
 /**
- * Sets the server zone , used for server api endpoint and dynamic configuration..
+ * Sets the server zone , used for server api endpoint and dynamic configuration.
  * @public
  * @param {string} serverZone - the server zone value. AmplitudeServerZone.US or AmplitudeServerZone.EU.
  * @param {bool} serverZoneBasedApi - (optional) update api endpoint with serverZone change or not. For data residency, recommend to enable it unless using own proxy server.

test/amplitude-client.js

@@ -4172,6 +4172,7 @@ describe('AmplitudeClient', function () {
     beforeEach(function () {
       reset();
     });
+
     it('should use default library options', function () {
       amplitude.init(apiKey);
       amplitude.logEvent('Event Type 1');
@@ -4189,41 +4190,20 @@ describe('AmplitudeClient', function () {
       assert.equal(version, '1.0-test');
     });
 
-    it('should change library when set with method', function () {
-      amplitude.init(apiKey);
-      amplitude.setLibrary('test-library', '1.0-test');
-      amplitude.logEvent('Event Type 2');
-
-      const { name, version } = JSON.parse(queryString.parse(server.requests[0].requestBody).e)[0].library;
-
-      assert.equal(name, 'test-library');
-      assert.equal(version, '1.0-test');
-    });
-  });
-
-  describe('libraryName', function () {
-    beforeEach(function () {
-      reset();
-    });
     it('should use the customize library name and default library version', function () {
       amplitude.init(apiKey);
-      amplitude.setLibraryName('test-library');
+      amplitude.setLibrary('test-library', undefined);
       amplitude.logEvent('Event Type');
 
       const { name, version } = JSON.parse(queryString.parse(server.requests[0].requestBody).e)[0].library;
 
       assert.equal(name, 'test-library');
       assert.equal(version, amplitude.options.library.version);
     });
-  });
 
-  describe('libraryVersion', function () {
-    beforeEach(function () {
-      reset();
-    });
     it('should use the customize library version and default library name', function () {
       amplitude.init(apiKey);
-      amplitude.setLibraryVersion('1.0-test');
+      amplitude.setLibrary(undefined, '1.0-test');
       amplitude.logEvent('Event Type');
 
       const { name, version } = JSON.parse(queryString.parse(server.requests[0].requestBody).e)[0].library;